Review main Merged Breaking

65797[!!!][TASK] Remove move placeholders

Benni Mack CR +2 V +2 Expert +870 −1368 updated 10/12/20, 16:59

Commit message

Workspaces ("Element-based versioning") previously had - due to
the "pid=-1" logic until TYPO3 v10 - a so-called "MOVE PLACEHOLDER".

This was indicated by t3ver_state = 3, all relevant fields:
* t3ver_state = 3 (move placeholder)
* t3ver_oid = 0 no connected live record, it allowed fetching these records
  with one query together with live records as db restrictions t3ver_oid > 0
* t3ver_wsid = workspace UID
* t3ver_move_id = UID of the live record
* pid = new PID the version was moved to
* sorting - when a record was moved within page with activated sorting

Other record fields were not important. However, when moving a record, the
value from TCA ctrl section "shadowColumnsForMovePlaceholders" was used to
fill in gaps from the live record.

The ACTUAL versioned record was indicated by t3ver_state = 4, the so-called
"MOVE POINTER". In previous version until TYPO3 v10, it's PID field was set
to -1, but since TYPO3 v10, it has the same PID as the "MOVE PLACEHOLDER".

Characteristics of the move pointer as of TYPO3 v10:
* t3ver_state = 4 (move pointer)
* t3ver_oid = UID of the live record
* t3ver_wsid = workspace UID
* t3ver_move_id = 0
* pid = PID the version was moved to
* sorting - same value as the live record (not evaluated until now)
* All other fields with optionally modified content

Both move placeholder and move pointer did not know each other directly.
Fetching the move pointer for a move placeheldor (or the other way around)
involved the live record, leading to many queries.

The patch obsoletes the move placeholder records, moving necessary
information to the move pointer: It now contains the updated sorting
and is considered in the Database Restrictions to be fetched.

In general, when publishing, the moved record now
behaves identical to the other versioned types.

This makes the internal code much easier, creates less DB queries
on read + write and leads to less DB records in the database.

The change removes creation of move placeholders, and considers the
move pointers when evaluating sorting and PID in DataHandler.

Read functionality from BackendUtility and PageRepository don't need an
additional step to fetch the live version of a move placeholder anymore.

An upgrade wizard takes existing move placeholders (state=3), updates
pid+sorting (PID generally not needed, just to be sure) of the move
pointer (state=4) and then deletes the move placeholder.

TCA definition $TCA[my-table][ctrl][shadowColumnsForMovePlaceholders]
is not needed anymore and removed by an auto TCA migration.

Finally, workspace enabled tables do not need the t3ver_move_id field
anymore: The live record UID is already in t3ver_oid field for state=4
records, just like with all other versioned records. The field will
be fully removed with a separate patch in order to keep the actual CSV
tests readable for this patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 94

Show 74 more files

Review log 4580

Show 2955 earlier messages
  1. Benni Mack uploaded patch set 1 09/21/20, 04:38

  2. TYPO3com voted on patch set 1 V -1 09/21/20, 04:50 Completed build in 11m 40s on Mon, 21 Sep, 04:50 AM Test Summary: 287 of 74143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5775

  3. Benni Mack uploaded patch set 2 09/21/20, 07:29

  4. TYPO3com voted on patch set 2 V -1 09/21/20, 07:30 Completed build in 32s on Mon, 21 Sep, 07:30 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5778

  5. Benni Mack uploaded patch set 3 09/21/20, 07:30

  6. TYPO3com voted on patch set 3 V -1 09/21/20, 07:43 Completed build in 12m 16s on Mon, 21 Sep, 07:43 AM Test Summary: 286 of 74143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5779

  7. Benni Mack uploaded patch set 4 09/21/20, 21:15

  8. Tymoteusz Motylewski commented on patch set 4 09/21/20, 21:26

    Wow!
  9. TYPO3com voted on patch set 4 V -1 09/21/20, 21:33 Completed build in 17m 13s on Mon, 21 Sep, 09:33 PM Test Summary: 295 of 74137 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5797

  10. Benni Mack uploaded patch set 5 09/21/20, 21:48

  11. TYPO3com voted on patch set 5 V -1 09/21/20, 21:49 Completed build in 39s on Mon, 21 Sep, 09:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5798

  12. Benni Mack uploaded patch set 6 09/21/20, 22:23

  13. TYPO3com voted on patch set 6 V -1 09/21/20, 22:36 Completed build in 12m 06s on Mon, 21 Sep, 10:36 PM Test Summary: 4558 of 73789 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5799

  14. Benni Mack uploaded patch set 7 09/22/20, 07:00

  15. TYPO3com voted on patch set 7 V -1 09/22/20, 07:12 Completed build in 11m 22s on Tue, 22 Sep, 07:12 AM Test Summary: 268 of 74137 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5801

  16. Benni Mack uploaded patch set 8 09/22/20, 07:30

  17. TYPO3com voted on patch set 8 V -1 09/22/20, 07:42 Completed build in 11m 30s on Tue, 22 Sep, 07:42 AM Test Summary: 262 of 74137 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5803

  18. Benni Mack uploaded patch set 9 09/22/20, 08:44

  19. Benni Mack uploaded patch set 10 09/22/20, 09:26

  20. Benni Mack uploaded patch set 11 09/22/20, 13:12

  21. TYPO3com voted on patch set 11 V -1 09/22/20, 13:24 Completed build in 11m 43s on Tue, 22 Sep, 01:24 PM Test Summary: 235 of 74155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5814

  22. Benni Mack uploaded patch set 12 09/22/20, 13:31

  23. Benni Mack uploaded patch set 13 09/22/20, 13:38

  24. TYPO3com voted on patch set 12 V -1 09/22/20, 13:44 Completed build in 12m 29s on Tue, 22 Sep, 01:44 PM Test Summary: 223 of 74155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5815

  25. TYPO3com voted on patch set 13 V -1 09/22/20, 13:51 Completed build in 12m 09s on Tue, 22 Sep, 01:51 PM Test Summary: 214 of 74155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5816

  26. Benni Mack uploaded patch set 14 09/22/20, 15:01

  27. TYPO3com voted on patch set 14 V -1 09/22/20, 15:13 Completed build in 11m 44s on Tue, 22 Sep, 03:13 PM Test Summary: 194 of 74155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5820

  28. Benni Mack uploaded patch set 15 09/22/20, 15:33

  29. TYPO3com voted on patch set 15 V -1 09/22/20, 15:44 Completed build in 11m 32s on Tue, 22 Sep, 03:44 PM Test Summary: 170 of 74155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5821

  30. Benni Mack uploaded patch set 16 09/22/20, 16:00

  31. TYPO3com voted on patch set 16 V -1 09/22/20, 16:13 Completed build in 12m 23s on Tue, 22 Sep, 04:13 PM Test Summary: 98 of 74155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5823

  32. Benni Mack uploaded patch set 17 09/22/20, 19:20

  33. TYPO3com voted on patch set 17 V -1 09/22/20, 19:31 Completed build in 10m 41s on Tue, 22 Sep, 07:31 PM Test Summary: 38 of 74155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5828

  34. Benni Mack uploaded patch set 18 09/29/20, 17:39

  35. TYPO3com voted on patch set 18 V -1 09/29/20, 17:53 Completed build in 13m 46s on Tue, 29 Sep, 05:53 PM Test Summary: 42 of 74169 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6072

  36. Benni Mack uploaded patch set 19 09/29/20, 20:06

  37. TYPO3com voted on patch set 19 V -1 09/29/20, 20:25 Completed build in 18m 50s on Tue, 29 Sep, 08:25 PM Test Summary: 46 of 74169 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6074

  38. Benni Mack uploaded patch set 20 09/29/20, 20:51

  39. Benni Mack uploaded patch set 21 09/29/20, 20:54

  40. TYPO3com voted on patch set 21 V -1 09/29/20, 21:10 Completed build in 16m 02s on Tue, 29 Sep, 09:10 PM Test Summary: 37 of 74169 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6076

  41. TYPO3com voted on patch set 20 V -1 09/29/20, 21:11 Completed build in 19m 32s on Tue, 29 Sep, 09:11 PM Test Summary: 37 of 74169 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6075

  42. Benni Mack updated the commit message in patch set 22 09/30/20, 07:14

  43. Benni Mack uploaded patch set 23 09/30/20, 07:23

  44. Benni Mack uploaded patch set 24 09/30/20, 07:26

  45. TYPO3com voted on patch set 22 V -1 09/30/20, 07:39 Completed build in 24m 13s on Wed, 30 Sep, 07:39 AM Test Summary: 27 of 72750 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6081

  46. TYPO3com voted on patch set 23 V -1 09/30/20, 07:40 Completed build in 17m 47s on Wed, 30 Sep, 07:40 AM Test Summary: 37 of 74169 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6082

  47. TYPO3com voted on patch set 24 V -1 09/30/20, 07:45 Completed build in 18m 09s on Wed, 30 Sep, 07:45 AM Test Summary: 37 of 74169 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6083

  48. Benni Mack uploaded patch set 25 09/30/20, 08:36

  49. TYPO3com voted on patch set 25 V -1 09/30/20, 08:50 Completed build in 13m 28s on Wed, 30 Sep, 08:50 AM Test Summary: 37 of 74169 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6084

  50. Benni Mack uploaded patch set 26 09/30/20, 08:58

  51. TYPO3com voted on patch set 26 V -1 09/30/20, 09:14 Completed build in 15m 48s on Wed, 30 Sep, 09:14 AM Test Summary: 37 of 74163 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6085

  52. Benni Mack uploaded patch set 27 10/02/20, 10:36

  53. TYPO3com voted on patch set 27 V -1 10/02/20, 10:49 Completed build in 12m 18s on Fri, 2 Oct, 10:49 AM Test Summary: 21 of 74163 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6163

  54. Benni Mack uploaded patch set 28 10/02/20, 12:42

  55. TYPO3com voted on patch set 28 V -1 10/02/20, 13:05 Completed build in 20m 58s on Fri, 2 Oct, 01:05 PM Test Summary: 15 of 74163 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6174

  1. Benni Mack uploaded patch set 29 10/02/20, 13:12

  2. TYPO3com voted on patch set 29 V -1 10/02/20, 13:45 Completed build in 32m 50s on Fri, 2 Oct, 01:45 PM Test Summary: 6 of 74163 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6180

  3. Benni Mack uploaded patch set 30 10/02/20, 13:57

  4. Benni Mack uploaded patch set 31 10/02/20, 14:19

  5. TYPO3com voted on patch set 30 V -1 10/02/20, 14:42 Completed build in 37m 24s on Fri, 2 Oct, 02:42 PM Test Summary: 1 of 74163 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6189

  6. TYPO3com voted on patch set 31 V -1 10/02/20, 15:15 Completed build in 53m 13s on Fri, 2 Oct, 03:15 PM Test Summary: 6 of 74187 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6195

  7. Benni Mack uploaded patch set 32 10/02/20, 15:56

  8. TYPO3com voted on patch set 32 V +1 10/02/20, 17:08 Completed build in 59m 05s on Fri, 2 Oct, 05:08 PM Test Summary: 73723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6215

  9. Benni Mack uploaded patch set 33 10/07/20, 08:14

  10. Benni Mack uploaded patch set 34 10/07/20, 08:24

  11. TYPO3com voted on patch set 33 V -1 10/07/20, 08:32 Completed build in 17m 58s on Wed, 7 Oct, 08:32 AM Test Summary: 6 of 74258 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6308

  12. TYPO3com voted on patch set 34 V -1 10/07/20, 08:49 Completed build in 23m 09s on Wed, 7 Oct, 08:49 AM Test Summary: 6 of 74258 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6310

  13. Benni Mack uploaded patch set 35 10/07/20, 09:32

  14. TYPO3com voted on patch set 35 V +1 10/07/20, 09:46 Completed build in 14m 12s on Wed, 7 Oct, 09:46 AM Test Summary: 73773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6313

  15. Christian Kuhn commented on patch set 35 CR -1 10/07/20, 10:41

    working on it
  16. Christian Kuhn commented on patch set 35 10/07/20, 17:02

    BackendUtility.php:3472 Unresolved

    typo here: t3ver_state

    moveParentContentToDifferentPageNChangeSorting.csv:15

    this looks as if child records are now resorted, too?
  17. Christian Kuhn uploaded patch set 36 10/07/20, 17:03

  18. Christian Kuhn commented on patch set 36 10/07/20, 17:04

    This looks good in general. Pushed some minor updates (hope that does not break anything). One detail related to irre sorting looks funny, should be investigated. Will continue with testing tomorrow.
  19. TYPO3com voted on patch set 36 V +1 10/07/20, 17:15 Completed build in 12m 34s on Wed, 7 Oct, 05:15 PM Test Summary: 73780 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6334

  20. Christian Kuhn commented on patch set 36 V +1 CR +1 10/12/20, 10:56

    moveParentContentToDifferentPageNChangeSorting.csv:15 Reply Unresolved

    This bug actually happens without patch, too. See https://forge.typo3.org/issues/92544 We should have a look at this with a dedicated patch.
  21. Oli Bartsch uploaded patch set 37 10/12/20, 16:43

  22. TYPO3com voted on patch set 37 V +1 10/12/20, 16:58 Completed build in 14m 32s on Mon, 12 Oct, 04:58 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6452

  23. Oli Bartsch voted on patch set 37 V +1 CR +1 10/12/20, 16:58

  24. Christian Kuhn voted on patch set 37 V +2 CR +2 10/12/20, 16:59

  25. Christian Kuhn merged patch set 38 10/12/20, 16:59