65800[TASK] Add field `flag` to LanguageMenuProcessor
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- Alexander Nitsche +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- Alexander Nitsche +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 910
-
Simon Gilli uploaded patch set 1 09/21/20, 18:28
-
Simon Gilli wrote 09/21/20, 18:38
Topic set to frontend -
TYPO3com voted on patch set 1 V +1 09/21/20, 18:41 Completed build in 12m 09s on Mon, 21 Sep, 06:41 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5795
-
Georg Ringer voted on patch set 1 V +1 CR +1 09/22/20, 08:19
-
Alexander Nitsche commented on patch set 1 V +1 CR +1 09/22/20, 08:41
All tests are fine. One question remains from the review: The following fields are provided by the SiteLanguage class but not provided yet by the LanguageMenuProcessor. Maybe one or the other should be added to LanguageMenuProcessor too? - base - websiteTitle - typo3Language - flagIdentifier I tested and approved: Test 1: without the applied patch, the flag attribute is not available in the frontend rendering Test 2: install introduction package and change language menu partial per description Test 3: run functional tests which use the LanguageMenuProcessor class (--filter SlugLinkGeneratorTest) Test 4: no particular test found which tests for provided fields of the LanguageMenuProcessor which would have to be updated / extended Test 5: compare files of main commits of class LanguageMenuProcessor and check if any associated file should be edited too: as this is not a feature, no release notes have to be added -
Oli Bartsch voted on patch set 1 V +1 CR +1 09/22/20, 08:52
-
Simon Gilli commented on patch set 1 09/22/20, 10:20
> One question remains from the review: The following fields are provided by the SiteLanguage class but not provided yet by the LanguageMenuProcessor. Maybe one or the other should be added to LanguageMenuProcessor too? > - base > - websiteTitle > - typo3Language > - flagIdentifier > Thanks for your propositions. flagIdentifier is added with this patch, typo3Language is used for the backend only iirc and also for the other fields I currently don't see a use case for a language menu. -
Alexander Nitsche commented on patch set 1 09/22/20, 10:40
> Thanks for your propositions. flagIdentifier is added with this patch, typo3Language is used for the backend only iirc and also for the other fields I currently don't see a use case for a language menu. Ok. -
Benni Mack voted on patch set 1 V +2 CR +2 09/22/20, 11:51
-
Benni Mack merged patch set 2 09/22/20, 11:51