Review main Merged

65801[FEATURE] Show fragments in preview of InputLinkElement

Georg Ringer CR +2 V +2 Easy +33 −1 updated 09/22/20, 08:51

Commit message

The rendertype `InputLinkElement` renders a preview of the link since #28171.

If a link to a page contains a fragment, this information has been
added to the preview.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Georg Ringer uploaded patch set 1 09/22/20, 06:51

  2. Georg Ringer commented on patch set 1 09/22/20, 06:51

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 09/22/20, 07:03 Completed build in 11m 43s on Tue, 22 Sep, 07:03 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5800

  4. Oli Bartsch commented on patch set 1 09/22/20, 07:14

    InputLinkElement.php:370 Unresolved

    Please cast the uid to int so we can sometimes make the methods signature strict. Why do we add additional where here? The uid should be unique.
  5. Georg Ringer commented on patch set 1 09/22/20, 07:39

    I want to avoid false positives as the anchor can also be set to anything
  6. Georg Ringer uploaded patch set 2 09/22/20, 08:11

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 09/22/20, 08:16

  8. TYPO3com voted on patch set 2 V +1 09/22/20, 08:26 Completed build in 14m 52s on Tue, 22 Sep, 08:26 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5805

  9. Benni Mack voted on patch set 2 V +2 CR +2 09/22/20, 08:51

  10. Benni Mack merged patch set 3 09/22/20, 08:51