65801[FEATURE] Show fragments in preview of InputLinkElement
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 810
-
Georg Ringer uploaded patch set 1 09/22/20, 06:51
-
Georg Ringer commented on patch set 1 09/22/20, 06:51
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 09/22/20, 07:03 Completed build in 11m 43s on Tue, 22 Sep, 07:03 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5800
-
Oli Bartsch commented on patch set 1 09/22/20, 07:14
InputLinkElement.php:370UnresolvedPlease cast the uid to int so we can sometimes make the methods signature strict. Why do we add additional where here? The uid should be unique. -
Georg Ringer commented on patch set 1 09/22/20, 07:39
I want to avoid false positives as the anchor can also be set to anything -
Georg Ringer uploaded patch set 2 09/22/20, 08:11
-
Oli Bartsch voted on patch set 2 V +1 CR +1 09/22/20, 08:16
-
TYPO3com voted on patch set 2 V +1 09/22/20, 08:26 Completed build in 14m 52s on Tue, 22 Sep, 08:26 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5805
-
Benni Mack voted on patch set 2 V +2 CR +2 09/22/20, 08:51
-
Benni Mack merged patch set 3 09/22/20, 08:51