Review main Merged

65804[BUGFIX] Fix uninitialized $queuedMessages in MemorySpool

Markus Gerdes CR +2 V +2 Easy +2 −2 updated 09/23/20, 08:56

Commit message

The protected member $queuedMessages of MemorySpool is now
initialized as empty array to prevent exceptions on accessing
it in magic methods like __toString().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1724

  1. Markus Gerdes uploaded patch set 1 09/22/20, 14:26

  2. TYPO3com voted on patch set 1 V -1 09/22/20, 14:27 Completed build in 21s on Tue, 22 Sep, 02:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5817

  3. Markus Gerdes uploaded patch set 2 09/22/20, 14:43

  4. TYPO3com commented on patch set 2 09/22/20, 14:43 Completed build in 21s on Tue, 22 Sep, 02:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5818

  5. Markus Gerdes uploaded patch set 3 09/22/20, 14:45

  6. TYPO3com voted on patch set 3 V +1 09/22/20, 14:57 Completed build in 11m 14s on Tue, 22 Sep, 02:57 PM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5819

  7. Christian Kuhn commented on patch set 3 09/22/20, 15:53

    MemorySpool.php:48 Unresolved

    Maybe just 'protected $queuedMessages = [];' instead here? This should obsolete the if in __toString()
  8. Markus Gerdes uploaded patch set 4 09/22/20, 17:08

  9. TYPO3com voted on patch set 4 V +1 09/22/20, 17:19 Completed build in 10m 44s on Tue, 22 Sep, 05:19 PM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5825

  10. Oliver Klee voted on patch set 4 CR +1 09/22/20, 18:05

  11. Alexander Schnitzler commented on patch set 4 CR -1 09/22/20, 18:41

    MemorySpool.php:75 Unresolved

    Please adjust this check here as well since we can check for an empty array now.
  12. Markus Gerdes uploaded patch set 5 09/23/20, 06:36

  13. TYPO3com voted on patch set 5 V +1 09/23/20, 06:49 Completed build in 13m 06s on Wed, 23 Sep, 06:49 AM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5839

  14. Oli Bartsch commented on patch set 5 CR -1 09/23/20, 06:52

    MemorySpool.php:75 Unresolved

    Please don't remove the check completely. Just check for $this->queuedMessages === [] now.
  15. Markus Gerdes uploaded patch set 6 09/23/20, 06:55

  16. TYPO3com voted on patch set 6 V +1 09/23/20, 07:07 Completed build in 11m 12s on Wed, 23 Sep, 07:07 AM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5842

  17. Oli Bartsch updated the commit message in patch set 7 09/23/20, 07:11

  18. Oli Bartsch voted on patch set 7 CR +1 09/23/20, 07:11

  19. TYPO3com voted on patch set 7 V +1 09/23/20, 07:23 Completed build in 11m 57s on Wed, 23 Sep, 07:23 AM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5843

  20. Alexander Schnitzler voted on patch set 7 V +1 CR +1 09/23/20, 07:26

  21. Oli Bartsch voted on patch set 7 V +1 09/23/20, 07:39

  22. Christian Kuhn voted on patch set 7 V +2 CR +2 09/23/20, 08:27

  23. Christian Kuhn merged patch set 8 09/23/20, 08:27

  24. Oliver Hader voted on patch set 8 CR +1 09/23/20, 08:56