Review main Merged

65807[BUGFIX] Update localized records when publishing default translation

Benni Mack CR +2 V +2 Normal +108 −21 updated 10/02/20, 07:18

Commit message

If an editor only published the default language,
then the localized records are left "hanging in" a workspace,
and are marked as deleted, this usually happened
when moving records.

The use-case however, more often is to publish a default
language first and then update the translations
when they are ready.

This change updated the l10n_parent and l10n_source fields
for the records on publish to use the live ID then,
but can be kept in the workspace.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1319

  1. Benni Mack uploaded patch set 1 09/22/20, 19:54

  2. TYPO3com voted on patch set 1 V -1 09/22/20, 20:05 Completed build in 10m 56s on Tue, 22 Sep, 08:05 PM Test Summary: 9 of 74161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5830

  3. Oliver Hader commented on patch set 1 CR -1 09/23/20, 07:11

    DataHandlerHook.php:842 Unresolved

    nitpick: `void`
  4. Benni Mack uploaded patch set 2 09/29/20, 15:47

  5. Benni Mack uploaded patch set 3 09/29/20, 15:51

  6. TYPO3com voted on patch set 2 V +1 09/29/20, 16:04 Completed build in 16m 39s on Tue, 29 Sep, 04:03 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6068

  7. TYPO3com voted on patch set 3 V +1 09/29/20, 16:04 Completed build in 13m 34s on Tue, 29 Sep, 04:04 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6069

  8. Oliver Hader commented on patch set 3 09/30/20, 07:09

    DataHandlerHook.php:869 Unresolved

    Something seems to be missing here? Assign/override $constraints?

    DataHandlerHook.php:903 Unresolved

    avoid touching records that don't need modification e.g. `if (empty($updateFields)) continue;`
  9. Oliver Hader voted on patch set 3 CR -1 09/30/20, 07:09

  10. Benni Mack uploaded patch set 4 09/30/20, 07:12

  11. TYPO3com voted on patch set 4 V -1 09/30/20, 07:30 Completed build in 17m 54s on Wed, 30 Sep, 07:30 AM Test Summary: 72614 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6080

  12. TYPO3com voted on patch set 4 V +1 09/30/20, 09:22 Completed build in 2h 28m 06s on Wed, 30 Sep, 09:22 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6080

  13. Christian Kuhn commented on patch set 4 09/30/20, 11:20

    DataHandlerHook.php:910 Unresolved

    * int cast on $record['uid'] missing (never rely on types returned by db) * for connection->update(), it's always better if you hand over argument 4 ($types) to allow proper quoting if you can. if that becomes unhandy, use queryBuilder->update() (in general i'm not a fan of the "shorthand" connection methods)
  14. Benni Mack uploaded patch set 5 09/30/20, 14:26

  15. TYPO3com voted on patch set 5 V +1 09/30/20, 14:38 Completed build in 11m 45s on Wed, 30 Sep, 02:38 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6102

  16. Christian Kuhn voted on patch set 5 V +1 CR +1 10/01/20, 20:36

  17. Georg Ringer voted on patch set 5 CR +1 10/01/20, 21:00

  18. Georg Ringer voted on patch set 5 V +2 CR +2 10/02/20, 07:18

  19. Georg Ringer merged patch set 6 10/02/20, 07:18