65807[BUGFIX] Update localized records when publishing default translation
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php4+92 −5
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/changeContentSorting.csv+4 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/changeContentSortingAfterSelf.csv+4 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/changeContentSortingAndCopyDraftPage.csv+4 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/moveContentToDifferentPageNChangeSorting.csv+4 −4
Review log 1319
-
Benni Mack uploaded patch set 1 09/22/20, 19:54
-
TYPO3com voted on patch set 1 V -1 09/22/20, 20:05 Completed build in 10m 56s on Tue, 22 Sep, 08:05 PM Test Summary: 9 of 74161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5830
-
Oliver Hader commented on patch set 1 CR -1 09/23/20, 07:11
-
Benni Mack uploaded patch set 2 09/29/20, 15:47
-
Benni Mack uploaded patch set 3 09/29/20, 15:51
-
TYPO3com voted on patch set 2 V +1 09/29/20, 16:04 Completed build in 16m 39s on Tue, 29 Sep, 04:03 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6068
-
TYPO3com voted on patch set 3 V +1 09/29/20, 16:04 Completed build in 13m 34s on Tue, 29 Sep, 04:04 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6069
-
Oliver Hader commented on patch set 3 09/30/20, 07:09
DataHandlerHook.php:869UnresolvedSomething seems to be missing here? Assign/override $constraints?DataHandlerHook.php:903Unresolvedavoid touching records that don't need modification e.g. `if (empty($updateFields)) continue;` -
Oliver Hader voted on patch set 3 CR -1 09/30/20, 07:09
-
Benni Mack uploaded patch set 4 09/30/20, 07:12
-
TYPO3com voted on patch set 4 V -1 09/30/20, 07:30 Completed build in 17m 54s on Wed, 30 Sep, 07:30 AM Test Summary: 72614 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6080
-
TYPO3com voted on patch set 4 V +1 09/30/20, 09:22 Completed build in 2h 28m 06s on Wed, 30 Sep, 09:22 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6080
-
Christian Kuhn commented on patch set 4 09/30/20, 11:20
DataHandlerHook.php:910Unresolved* int cast on $record['uid'] missing (never rely on types returned by db) * for connection->update(), it's always better if you hand over argument 4 ($types) to allow proper quoting if you can. if that becomes unhandy, use queryBuilder->update() (in general i'm not a fan of the "shorthand" connection methods) -
Benni Mack uploaded patch set 5 09/30/20, 14:26
-
TYPO3com voted on patch set 5 V +1 09/30/20, 14:38 Completed build in 11m 45s on Wed, 30 Sep, 02:38 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6102
-
Christian Kuhn voted on patch set 5 V +1 CR +1 10/01/20, 20:36
-
Georg Ringer voted on patch set 5 CR +1 10/01/20, 21:00
-
Georg Ringer voted on patch set 5 V +2 CR +2 10/02/20, 07:18
-
Georg Ringer merged patch set 6 10/02/20, 07:18
DataHandlerHook.php:842Unresolved