Review main Merged

65808[BUGFIX] Check for columns before iterating over those in page module

Georg Ringer CR +2 V +2 Easy +5 −3 updated 09/23/20, 09:49

Commit message

Check if there are any columns before iterating over those in the
fluid page module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Claus Due +1
    • Georg Tiefenbrunn +1
    • Josef Glatz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Tiefenbrunn +1
    • Josef Glatz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Georg Ringer uploaded patch set 1 09/22/20, 20:46

  2. Georg Ringer commented on patch set 1 09/22/20, 20:46

    This change is ready for review.
  3. Claus Due voted on patch set 1 CR +1 09/22/20, 20:49

  4. Georg Tiefenbrunn voted on patch set 1 CR +1 09/22/20, 20:57

  5. TYPO3com voted on patch set 1 V +1 09/22/20, 20:58 Completed build in 11m 30s on Tue, 22 Sep, 08:58 PM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5831

  6. Oli Bartsch commented on patch set 1 09/22/20, 21:24

    LanguageColumns.html:68

    Would preffer checking `languageColumn.grid.columns` prior to the variable declarations to avoid unecessary VH calls.
  7. Claus Due commented on patch set 1 09/22/20, 21:31

    LanguageColumns.html:68 Reply

    This is not possible; the reason the variable is assigned is to pass _all to f:render below, the partial that is rendered requires {grid} to be set. It's also not a change introduced by this patch set.
  8. Georg Ringer uploaded patch set 2 09/23/20, 06:26

  9. Oli Bartsch commented on patch set 2 V +1 CR +1 09/23/20, 06:34

    LanguageColumns.html:68 Reply

    If grid.columns doesn't evaluate to true, the partial won't be called at all and the variable declaration beforehand is unnecessary.
  10. TYPO3com voted on patch set 2 V +1 09/23/20, 06:38 Completed build in 12m 29s on Wed, 23 Sep, 06:38 AM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5838

  11. Josef Glatz voted on patch set 2 V +1 CR +1 09/23/20, 06:44

  12. Georg Tiefenbrunn voted on patch set 2 V +1 CR +1 09/23/20, 06:50

  13. Claus Due commented on patch set 2 CR +1 09/23/20, 07:25

    LanguageColumns.html:68 Reply Unresolved

    Right, sorry, I misunderstood your comment. I thought you wanted to remove the f:variable altogether. As for performance: there's really no difference. Not doing the f:variable assignment saves two function calls - but adding another segment to the property path that is checked adds two function calls that cost approximately the same.
  14. Benni Mack voted on patch set 2 V +2 CR +2 09/23/20, 09:49

  15. Benni Mack merged patch set 3 09/23/20, 09:49