65808[BUGFIX] Check for columns before iterating over those in page module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Claus Due +1
- Georg Tiefenbrunn +1
- Josef Glatz +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Tiefenbrunn +1
- Josef Glatz +1
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1315
-
Georg Ringer uploaded patch set 1 09/22/20, 20:46
-
Georg Ringer commented on patch set 1 09/22/20, 20:46
This change is ready for review. -
Claus Due voted on patch set 1 CR +1 09/22/20, 20:49
-
Georg Tiefenbrunn voted on patch set 1 CR +1 09/22/20, 20:57
-
TYPO3com voted on patch set 1 V +1 09/22/20, 20:58 Completed build in 11m 30s on Tue, 22 Sep, 08:58 PM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5831
-
Oli Bartsch commented on patch set 1 09/22/20, 21:24
LanguageColumns.html:68Would preffer checking `languageColumn.grid.columns` prior to the variable declarations to avoid unecessary VH calls. -
Claus Due commented on patch set 1 09/22/20, 21:31
LanguageColumns.html:68ReplyThis is not possible; the reason the variable is assigned is to pass _all to f:render below, the partial that is rendered requires {grid} to be set. It's also not a change introduced by this patch set. -
Georg Ringer uploaded patch set 2 09/23/20, 06:26
-
Oli Bartsch commented on patch set 2 V +1 CR +1 09/23/20, 06:34
LanguageColumns.html:68ReplyIf grid.columns doesn't evaluate to true, the partial won't be called at all and the variable declaration beforehand is unnecessary. -
TYPO3com voted on patch set 2 V +1 09/23/20, 06:38 Completed build in 12m 29s on Wed, 23 Sep, 06:38 AM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5838
-
Josef Glatz voted on patch set 2 V +1 CR +1 09/23/20, 06:44
-
Georg Tiefenbrunn voted on patch set 2 V +1 CR +1 09/23/20, 06:50
-
Claus Due commented on patch set 2 CR +1 09/23/20, 07:25
LanguageColumns.html:68Reply UnresolvedRight, sorry, I misunderstood your comment. I thought you wanted to remove the f:variable altogether. As for performance: there's really no difference. Not doing the f:variable assignment saves two function calls - but adding another segment to the property path that is checked adds two function calls that cost approximately the same. -
Benni Mack voted on patch set 2 V +2 CR +2 09/23/20, 09:49
-
Benni Mack merged patch set 3 09/23/20, 09:49