65810[TASK] Local variable $resolvedIds in PlainDataResolver
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 79
-
Christian Kuhn uploaded patch set 1 09/22/20, 23:11
-
Christian Kuhn updated the commit message in patch set 2 09/22/20, 23:15
-
TYPO3com voted on patch set 1 V +1 09/22/20, 23:27 Completed build in 15m 48s on Tue, 22 Sep, 11:27 PM Test Summary: 73674 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5836
-
TYPO3com voted on patch set 2 V +1 09/22/20, 23:32 Completed build in 14m 21s on Tue, 22 Sep, 11:31 PM Test Summary: 73675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5837
-
Georg Ringer voted on patch set 2 V +1 CR +1 09/23/20, 00:11
-
Daniel Goerz commented on patch set 2 09/23/20, 06:59
-
Christian Kuhn commented on patch set 2 09/23/20, 07:22
PlainDataResolver.php:140Reply UnresolvedAll get() usages simply makeInstance->setters()->get() - so even if that variable was intended to be a local cache, it is not used as such. Wouldn't make sense to cache it anyway (depending on which exact input?) -
Benni Mack commented on patch set 2 V +2 CR +2 09/23/20, 08:21
agree with Christian, this state looks unnecessarry based on the usages. -
Benni Mack merged patch set 3 09/23/20, 08:21
PlainDataResolver.php:140