Review 10.4 Merged

65812[BUGFIX] Remove pre-checks on "transport_spool_filepath"

Daniel Goerz CR +2 V +2 Easy +2 −2 updated 09/21/20, 12:51

Commit message

FileSpool uses GeneralUtility::mkdir_deep() if path does not exist.
mkdir_deep() also tries to fix permissions.
Even if this fails, there are further writable-checks down the line
in \TYPO3\CMS\Core\Mail\FileSpool constructor.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 09/21/20, 12:35

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/21/20, 12:48 Completed build in 12m 16s on Mon, 21 Sep, 12:48 PM Test Summary: 74702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-447

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 09/21/20, 12:51

  4. Daniel Goerz merged patch set 2 09/21/20, 12:51