Review 10.4 Merged

65815[TASK] Always send 404 response on hidden pages

Christian Kuhn CR +2 V +2 Normal +221 −4 updated 09/22/20, 15:31

Commit message

As a backend user, it is possible to preview a hidden page & record
in a workspace, however, without a user it is not possible.

Adding the tests also discovered that access to a "hidden" page should
result in a 404 instead of 403 response (even though the page
has access restrictions or not) in a live environment.

This change adds tests to ensure this functionality is always working.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 3

Files 11

Review log 46

  1. Christian Kuhn commented on patch set 1 09/22/20, 12:22

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 09/22/20, 12:36 Completed build in 14m 15s on Tue, 22 Sep, 12:36 PM Test Summary: 1 of 74836 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-452

  3. TYPO3com voted on patch set 1 V +1 09/22/20, 13:06 Completed build in 58m 25s on Tue, 22 Sep, 01:06 PM Test Summary: 74720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-452

  4. Benni Mack voted on patch set 1 V +2 CR +2 09/22/20, 13:48

  5. Benni Mack merged patch set 2 09/22/20, 13:49

  6. Oliver Hader voted on patch set 2 CR +1 09/22/20, 15:31