Review 10.4 Merged

65821[TASK] Add tests for Extbase DateTimeConverter

Christian Kuhn CR +2 V +2 Easy +16 −11 updated 09/23/20, 11:36

Commit message

Some older PHP versions could not handle DateTime::createFromFormat()
with negative integers.

This change adds tests to show that this actually works.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 09/23/20, 10:58

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/23/20, 11:09 Completed build in 11m 09s on Wed, 23 Sep, 11:09 AM Test Summary: 74720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-462

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 09/23/20, 11:35

  4. Christian Kuhn merged patch set 2 09/23/20, 11:36