Review 10.4 Merged

65824[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Http

Daniel Goerz CR +2 V +2 Easy +6 −6 updated 09/23/20, 17:17

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 35

  1. Daniel Goerz commented on patch set 1 09/23/20, 14:13

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 09/23/20, 14:36 Completed build in 15m 59s on Wed, 23 Sep, 02:36 PM Test Summary: 1 of 75205 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-465

  3. TYPO3com voted on patch set 1 V +1 09/23/20, 14:55 Completed build in 50m 46s on Wed, 23 Sep, 02:55 PM Test Summary: 74720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-465

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 09/23/20, 17:17

  5. Daniel Goerz merged patch set 2 09/23/20, 17:17