Review 10.4 Merged

65825[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core LinkHandling

Daniel Goerz CR +2 V +2 Easy +1 −1 updated 09/23/20, 14:48

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Daniel Goerz commented on patch set 1 09/23/20, 14:20

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/23/20, 14:45 Completed build in 25m 11s on Wed, 23 Sep, 02:45 PM Test Summary: 74720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-466

  3. Oliver Klee voted on patch set 1 CR +1 09/23/20, 14:46

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 09/23/20, 14:48

  5. Daniel Goerz merged patch set 2 09/23/20, 14:48