Review 10.4 Merged

65826[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Authentication

Benni Mack CR +2 V +2 Easy +12 −8 updated 09/23/20, 16:18

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Benni Mack commented on patch set 1 09/23/20, 14:27

    Cherry Picked from branch master.
  2. Oliver Klee voted on patch set 1 CR +1 09/23/20, 14:46

  3. TYPO3com voted on patch set 1 V +1 09/23/20, 14:54 Completed build in 16m 54s on Wed, 23 Sep, 02:54 PM Test Summary: 74720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-467

  4. Benni Mack voted on patch set 1 V +2 CR +2 09/23/20, 16:18

  5. Benni Mack merged patch set 2 09/23/20, 16:18