65829[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:frontend
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Andreas Kienast +1
-
Verified V +2 Done
- Daniel Goerz +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 20
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+83 −51
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ScalableVectorGraphicsContentObject.php+2 −2
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+7 −7
- typo3/sysext/frontend/Classes/DataProcessing/CommaSeparatedValueProcessor.php+2 −2
- typo3/sysext/frontend/Classes/DataProcessing/FilesProcessor.php+3 −3
- typo3/sysext/frontend/Classes/DataProcessing/SplitProcessor.php+1 −1
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+8 −4
- typo3/sysext/frontend/Classes/Page/CacheHashConfiguration.php+2 −2
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+6 −6
- typo3/sysext/frontend/Classes/Resource/FileCollector.php+3 −0
- typo3/sysext/frontend/Classes/Typolink/FileOrFolderLinkBuilder.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/LegacyLinkBuilder.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+3 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php+1 −1
Review log 1926
Show 1 earlier messages
-
Daniel Goerz commented on patch set 1 09/23/20, 16:39
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php * typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php * typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php * typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php * typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php * typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php * typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php * typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php * typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php * typo3/sysext/frontend/Classes/ContentObject/ScalableVectorGraphicsContentObject.php * typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php * typo3/sysext/frontend/Classes/DataProcessing/FilesProcessor.php * typo3/sysext/frontend/Classes/Imaging/GifBuilder.php
-
TYPO3com voted on patch set 1 V -1 09/23/20, 16:56 Completed build in 42s on Wed, 23 Sep, 04:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-471
-
Daniel Goerz uploaded patch set 2 09/23/20, 16:57
-
Daniel Goerz commented on patch set 2 09/23/20, 17:00
This change is ready for review. -
Daniel Goerz commented on patch set 2 09/23/20, 17:01
Cherry-picked with --strategy=recursive -X ours because of tons of conflicts due to master only patches in this area -
Oliver Klee voted on patch set 2 CR +1 09/23/20, 17:36
-
TYPO3com voted on patch set 2 V -1 09/23/20, 17:41 Completed build in 21m 25s on Wed, 23 Sep, 05:41 PM Test Summary: 74735 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-472
-
Daniel Goerz uploaded patch set 3 09/23/20, 18:03
-
TYPO3com voted on patch set 3 V +1 09/23/20, 18:15 Completed build in 11m 15s on Wed, 23 Sep, 06:15 PM Test Summary: 74737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-475
-
Oliver Klee voted on patch set 3 CR +1 09/23/20, 18:44
-
Alexander Schnitzler rebased onto patch set 4 09/25/20, 09:32
-
TYPO3com voted on patch set 4 V +1 09/25/20, 09:52 Completed build in 17m 20s on Fri, 25 Sep, 09:52 AM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-488
-
Oliver Klee voted on patch set 4 CR +1 09/25/20, 09:56
-
Daniel Goerz rebased onto patch set 5 09/25/20, 10:05
-
Oliver Klee voted on patch set 5 CR +1 09/25/20, 10:11
-
TYPO3com voted on patch set 5 V +1 09/25/20, 10:18 Completed build in 12m 40s on Fri, 25 Sep, 10:18 AM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-491
-
Daniel Goerz rebased onto patch set 6 09/25/20, 10:37
-
Oliver Klee voted on patch set 6 CR +1 09/25/20, 10:39
-
TYPO3com voted on patch set 6 V +1 09/25/20, 10:51 Completed build in 13m 42s on Fri, 25 Sep, 10:51 AM Test Summary: 74747 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-494
-
Andreas Kienast commented on patch set 6 V -1 09/26/20, 09:17
Which parameters.checkFunctionArgumentTypes enabled, phpstan still finds 7 errors. -
Andreas Kienast uploaded patch set 7 09/26/20, 09:29
-
Andreas Kienast commented on patch set 7 V +1 CR +1 09/26/20, 09:30
There are still errors left but those are now the same as in master. IMO we should have another patch fixing the leftover issues for both branches then. -
TYPO3com voted on patch set 7 V +1 09/26/20, 09:42 Completed build in 12m 43s on Sat, 26 Sep, 09:42 AM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-510
-
Daniel Goerz commented on patch set 7 V -1 09/26/20, 09:49
> Patch Set 7: Verified+1 Code-Review+1 > > There are still errors left but those are now the same as in master. IMO we should have another patch fixing the leftover issues for both branches then. That is the plan, exactly. I'll have a look at this one today, I'll -1 so that it does not get merged before -
Daniel Goerz commented on patch set 7 V +2 CR +2 09/26/20, 10:32
Thanks Andi! -
Daniel Goerz merged patch set 8 09/26/20, 10:33