Review 10.4 Merged

65830[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Routing

Daniel Goerz CR +2 V +2 Easy +10 −9 updated 09/23/20, 18:38

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 46

  1. Daniel Goerz commented on patch set 1 09/23/20, 17:06

    Cherry Picked from branch master.
  2. Oliver Klee voted on patch set 1 CR +1 09/23/20, 17:25

  3. TYPO3com voted on patch set 1 V -1 09/23/20, 17:51 Completed build in 30m 39s on Wed, 23 Sep, 05:50 PM Test Summary: 2 of 75220 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-473

  4. TYPO3com voted on patch set 1 V +1 09/23/20, 18:06 Completed build in 1h 17m 09s on Wed, 23 Sep, 06:06 PM Test Summary: 74735 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-473

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 09/23/20, 18:38

  6. Daniel Goerz merged patch set 2 09/23/20, 18:38