Review main Merged

65832[BUGFIX] Send specific value when unchecking items in TypoScript module

Oliver Hader CR +2 V +2 Easy +22 −2 updated 09/23/20, 09:27

Commit message

Using `GlobalEventHandler` in combination with checkboxes and unchecking
on item uses and empty string `''` as value for that particular parameter
(e.g. `&setting=`). However, some scenarios in the TYPO3 backend rely on
receiving `&setting=0` instead - e.g. see BackendUtility::getModuleData().

New attribute `data-empty-value` has been introduced to achieve that.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 67

  1. Oliver Hader uploaded patch set 1 09/23/20, 08:49

  2. TYPO3com voted on patch set 1 V +1 09/23/20, 09:01 Completed build in 12m 16s on Wed, 23 Sep, 09:01 AM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5846

  3. Richard Haeser voted on patch set 1 V +1 CR +1 09/23/20, 09:12

  4. Georg Ringer voted on patch set 1 V +1 09/23/20, 09:27

  5. Georg Ringer voted on patch set 1 CR +1 09/23/20, 09:27

  6. Georg Ringer voted on patch set 1 V +2 CR +2 09/23/20, 09:27

  7. Georg Ringer merged patch set 2 09/23/20, 09:27