Review main Merged

65834[TASK] Add tests for Extbase DateTimeConverter

Benni Mack CR +2 V +2 Easy +16 −11 updated 09/23/20, 10:57

Commit message

Some older PHP versions could not handle DateTime::createFromFormat()
with negative integers.

This change adds tests to show that this actually works.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 09/23/20, 09:19

  2. TYPO3com voted on patch set 1 V +1 09/23/20, 09:31 Completed build in 11m 46s on Wed, 23 Sep, 09:31 AM Test Summary: 73682 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5847

  3. Alexander Schnitzler voted on patch set 1 V +1 CR +1 09/23/20, 10:26

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 09/23/20, 10:52

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 09/23/20, 10:57

  6. Christian Kuhn merged patch set 2 09/23/20, 10:57