65835[TASK] Deprecate @Extbase\Inject
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 22
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-92386-ExtbasePropertyInjectionIsDeprecated.rst6new+68 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/AbstractController.php+5 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/ContentController.php+10 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/QueueController.php+10 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/Services.yamlnew+9 −0
- typo3/sysext/extbase/Classes/Annotation/Inject.php+1 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+4 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+10 −5
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/ContentController.php+10 −5
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/Services.yamlnew+9 −0
- typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php+0 −11
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/PropertyTest.php+0 −11
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfProperties.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+0 −23
- typo3/sysext/extbase/Tests/UnitDeprecated/Object/Container/Fixtures/ContainerPropertyInjectionTestClasses.phprenamed+3 −3
- typo3/sysext/extbase/Tests/UnitDeprecated/Object/Container/ContainerTest.phpnew+82 −0
- typo3/sysext/extbase/Tests/UnitDeprecated/Reflection/ClassSchema/PropertyTest.phpnew+39 −0
- typo3/sysext/extbase/Tests/UnitDeprecated/Reflection/Fixture/DummyClassWithAllTypesOfProperties.phprenamed+8 −9
- typo3/sysext/extbase/Tests/UnitDeprecated/Reflection/Fixture/DummyClassWithInjectDoctrineAnnotation.phprenamed+4 −4
- typo3/sysext/extbase/Tests/UnitDeprecated/Reflection/ClassSchemaTest.phpnew+48 −0
Review log 2133
Show 58 earlier messages
-
Alexander Schnitzler uploaded patch set 1 09/23/20, 11:09
-
TYPO3com voted on patch set 1 V -1 09/23/20, 11:20 Completed build in 11m 04s on Wed, 23 Sep, 11:20 AM Test Summary: 460 of 74167 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5850
-
Alexander Schnitzler uploaded patch set 2 09/23/20, 11:48
-
TYPO3com voted on patch set 2 V -1 09/23/20, 12:04 Completed build in 15m 03s on Wed, 23 Sep, 12:04 PM Test Summary: 157 of 74167 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5853
-
Alexander Schnitzler uploaded patch set 3 09/23/20, 12:14
-
Alexander Schnitzler uploaded patch set 4 09/23/20, 12:26
-
TYPO3com voted on patch set 3 V -1 09/23/20, 12:27 Completed build in 12m 42s on Wed, 23 Sep, 12:27 PM Test Summary: 85 of 74167 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5855
-
Alexander Schnitzler wrote 09/23/20, 12:31
Topic set to extbase
-
TYPO3com voted on patch set 4 V -1 09/23/20, 12:44 Completed build in 18m 23s on Wed, 23 Sep, 12:44 PM Test Summary: 1 of 74167 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5857
-
Alexander Schnitzler uploaded patch set 5 09/23/20, 13:08
-
TYPO3com voted on patch set 5 V -1 09/23/20, 13:20 Completed build in 12m 15s on Wed, 23 Sep, 01:20 PM Test Summary: 84 of 74167 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5858
-
Alexander Schnitzler uploaded patch set 6 09/23/20, 13:50
-
TYPO3com voted on patch set 6 V -1 09/23/20, 13:52 Completed build in 32s on Wed, 23 Sep, 01:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5861
-
Alexander Schnitzler uploaded patch set 7 09/23/20, 13:53
-
TYPO3com voted on patch set 7 V +1 09/23/20, 14:07 Completed build in 13m 28s on Wed, 23 Sep, 02:07 PM Test Summary: 73671 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5862
-
Alexander Schnitzler uploaded patch set 8 09/23/20, 16:05
-
TYPO3com voted on patch set 8 V -1 09/23/20, 16:18 Completed build in 12m 40s on Wed, 23 Sep, 04:18 PM Test Summary: 42 of 74179 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5881
-
Alexander Schnitzler uploaded patch set 9 12/05/20, 11:34
-
TYPO3com voted on patch set 9 V +1 12/05/20, 11:44 Completed build in 09m 42s on Sat, 5 Dec, 11:44 AM Test Summary: 32412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7823
-
Alexander Schnitzler commented on patch set 9 12/05/20, 12:22
This change is ready for review. -
Benjamin Franzke uploaded patch set 10 12/05/20, 20:38
-
TYPO3com voted on patch set 10 V +1 12/05/20, 20:46 Completed build in 08m 31s on Sat, 5 Dec, 08:46 PM Test Summary: 32412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7839
-
Benjamin Franzke uploaded patch set 11 12/06/20, 06:53
-
TYPO3com voted on patch set 11 V +1 12/06/20, 07:02 Completed build in 08m 47s on Sun, 6 Dec, 07:02 AM Test Summary: 32410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7844
-
Torben Hansen voted on patch set 11 CR +1 12/06/20, 18:06
-
Georg Ringer commented on patch set 11 CR -1 12/08/20, 18:18
Deprecation-92386-ExtbasePropertyInjectionIsDeprecated.rst:30please add examples to at least the most simpliest of those as otherwise extension developers who are more the extension-builder users are completly left aloneDeprecation-92386-ExtbasePropertyInjectionIsDeprecated.rst:34either use Dependency Injection -
Alexander Schnitzler commented on patch set 11 12/08/20, 19:06
Deprecation-92386-ExtbasePropertyInjectionIsDeprecated.rst:30ReplyWhat about directing the users to the documentation instead? Do we need to repeat ourselves all the time? https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/DependencyInjection/Index.html This exists and I don't want to copy it over to this doc to be honest.Deprecation-92386-ExtbasePropertyInjectionIsDeprecated.rst:34Replyeither? Sorry, don't understand the sentence. -
Benjamin Franzke uploaded patch set 12 12/14/20, 15:11
-
Benjamin Franzke commented on patch set 12 12/14/20, 15:11
Deprecation-92386-ExtbasePropertyInjectionIsDeprecated.rst:30ReplyDoneDeprecation-92386-ExtbasePropertyInjectionIsDeprecated.rst:34ReplyDone -
TYPO3com voted on patch set 12 V +1 12/14/20, 15:21 Completed build in 09m 43s on Mon, 14 Dec, 03:21 PM Test Summary: 32412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8171
-
Georg Ringer voted on patch set 12 V +1 CR +1 12/14/20, 21:20
-
Benjamin Franzke voted on patch set 12 V +2 CR +2 12/14/20, 22:05
-
Benjamin Franzke merged patch set 13 12/14/20, 22:05