Review main Abandoned

65836[TASK] Use option exposeRedirectInformation for redirect of EXT:redirects

Georg Ringer CR 0 V 0 Easy +18 −1 updated 10/19/21, 18:48

Commit message

Redirects triggered by the extension "redirects" respect the global option
`$GLOBALS['TYPO3_CONF_VARS']['FE']['exposeRedirectInformation']`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1113

  1. Georg Ringer uploaded patch set 1 09/23/20, 12:23

  2. Georg Ringer commented on patch set 1 09/23/20, 12:23

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 09/23/20, 12:36 Completed build in 12m 38s on Wed, 23 Sep, 12:35 PM Test Summary: 73682 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5856

  4. Guido Schmechel commented on patch set 1 09/23/20, 16:14

    I found one more place here: - typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php Doesn't it make sense to integrate the query there as well? I also think it would be great if we could secure the new query with a simple test. What do you mean?
  5. Georg Ringer commented on patch set 1 09/24/20, 03:25

    > Patch Set 1: > > I found one more place here: > > - typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php > > Doesn't it make sense to integrate the query there as well? I also think it would be great if we could secure the new query with a simple test. > > What do you mean? What do you mean? Redirect information has been added there already
  6. Guido Schmechel commented on patch set 1 09/24/20, 08:05

    > What do you mean? Redirect information has been added there already My mistake. exposeRedirectInformation is used there. Sorry! But the question with the test is still open :-)
  7. Josef Glatz commented on patch set 1 V -1 09/24/20, 12:15

    Important-92384-HideRedirectInformationBehindOption.rst:12 Unresolved

    intended to repeat the inline code language meta info?
  8. Georg Ringer uploaded patch set 2 09/25/20, 08:18

  9. TYPO3com voted on patch set 2 V +1 09/25/20, 08:30 Completed build in 11m 57s on Fri, 25 Sep, 08:30 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5928

  10. Torben Hansen voted on patch set 2 CR +1 09/26/20, 11:10

  11. Daniel Goerz commented on patch set 2 09/26/20, 12:47

    Honest question: What is sensitive about the uid of a redirect record? I can see this for a page uid, but not so much for a redirect. Having this switch in place would make me want to enable it for redirects and disable it for pages.
  12. Oliver Hader commented on patch set 2 09/28/20, 07:11

    > Patch Set 2: > > Honest question: What is sensitive about the uid of a redirect record? I can see this for a page uid, but not so much for a redirect. Having this switch in place would make me want to enable it for redirects and disable it for pages. None. There is no impact for uids of redirect records. In general I would have assumed that this option is able to disable the HTTP header from being exposed in general ("no X-Redirected-By at all")... Besides that Helmut raised an interesting idea of using better logging in the previous change - which unfortunately was not considered.
  13. Georg Ringer abandoned the change 10/19/21, 18:48

    abandoned, no interest