Review main Merged

65838[BUGFIX] Do not translate move pointers in workspace

Benni Mack CR +2 V +2 Normal +79 −14 updated 09/23/20, 16:37

Commit message

When a moved content element in a workspace got copied
(or the whole page that the content element is put),
then the content element is added twice to the target
page.

This patch skips moved placeholders completely.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1

Issues 1

Files 6

Review log 1621

  1. Benni Mack uploaded patch set 1 09/23/20, 15:01

  2. Benni Mack updated the commit message in patch set 2 09/23/20, 15:09

  3. Oliver Hader commented on patch set 1 09/23/20, 15:09

    DataHandler.php:3886 Unresolved

    Probably a good position to ignore deleted-placeholders as well? I'm wondering where that is/was handled!?
  4. TYPO3com voted on patch set 1 V -1 09/23/20, 15:21 Completed build in 16m 03s on Wed, 23 Sep, 03:21 PM Test Summary: 4 of 74167 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5873

  5. TYPO3com voted on patch set 2 V -1 09/23/20, 15:25 Completed build in 14m 06s on Wed, 23 Sep, 03:25 PM Test Summary: 4 of 74167 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5874

  6. Benni Mack uploaded patch set 3 09/23/20, 15:52

  7. Oliver Hader commented on patch set 3 09/23/20, 15:56

    changeContentSortingAndCopyDraftPage.csv:29 Unresolved

    Should be 2, 1, 3 -> element #2 was moved after element #1
  8. TYPO3com voted on patch set 3 V +1 09/23/20, 16:08 Completed build in 13m 34s on Wed, 23 Sep, 04:08 PM Test Summary: 73699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5879

  9. Oliver Hader commented on patch set 3 09/23/20, 16:11

    changeContentSortingAndCopyDraftPage.csv:12 Unresolved

    origUid is applied to all versions in DataHandler::versionizeRecord, calling DataHandler::copyRecord_raw
  10. Oliver Hader voted on patch set 3 CR +1 09/23/20, 16:13

  11. Oliver Hader commented on patch set 4 09/23/20, 16:13

    Published edit on patch set 3.
  12. Oliver Hader voted on patch set 4 CR +1 09/23/20, 16:13

  13. Oliver Hader updated the commit message in patch set 5 09/23/20, 16:18

  14. Oliver Hader updated the commit message in patch set 6 09/23/20, 16:23

  15. Oliver Hader commented on patch set 6 09/23/20, 16:24

    My mistake: #92372 is not related here
  16. TYPO3com voted on patch set 4 V +1 09/23/20, 16:26 Completed build in 12m 47s on Wed, 23 Sep, 04:26 PM Test Summary: 73698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5882

  17. Oliver Hader voted on patch set 6 V +1 09/23/20, 16:28

  18. Oliver Hader commented on patch set 6 09/23/20, 16:28

    Tested in TYPO3 v10 as well +1
  19. Christian Kuhn voted on patch set 6 V +2 CR +2 09/23/20, 16:37

  20. TYPO3com voted on patch set 5 V +1 09/23/20, 16:37 Completed build in 14m 54s on Wed, 23 Sep, 04:37 PM Test Summary: 73699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5884

  21. Christian Kuhn merged patch set 7 09/23/20, 16:37