Review main Abandoned

65839[FEATURE] Extbase action controllers process typo script variables

Thorben Nissen CR 0 V 0 Normal +75 −0 updated 11/09/21, 22:23

Commit message

Extbase action controller processes the variables section of the plugin's
typo script configuration. This is similar to the processing in the
FLUIDTEMPLATE content element.

The content object's data is always added. The variable name for the
content object data can defined with `contentObjectDataAs` in the
plugin's typo script settings (defaults to `data`).

The actual controller can define a list of reserved variables, which
causes an exception to be thrown, if a variable with that name is defined
in typo script.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 79

  1. Thorben Nissen uploaded patch set 1 09/23/20, 15:29

  2. TYPO3com voted on patch set 1 V -1 09/23/20, 15:42 Completed build in 13m 11s on Wed, 23 Sep, 03:42 PM Test Summary: 73351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5875

  3. Thorben Nissen uploaded patch set 2 09/23/20, 17:59

  4. TYPO3com voted on patch set 2 V +1 09/23/20, 18:11 Completed build in 11m 23s on Wed, 23 Sep, 06:11 PM Test Summary: 73699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5898

  5. Daniel Goerz wrote 09/26/20, 12:38

    Topic set to extbase
  6. Oliver Klee commented on patch set 2 09/28/20, 14:15

    Can we cover this with tests so we can be sure this works correctly and does not break in the future?
  7. Alexander Schnitzler commented on patch set 2 CR -1 09/28/20, 14:41

    Can you please add an example to the rst file? by reading the commit message and the rst file I currently don't know what this feature enables me to do.
  8. Christian Kuhn commented on patch set 2 11/09/21, 22:23

    Hey. I'm unsure if I understand the full impact of this change. It seems as if this makes extbase controller/action configuration even more flexible by parsing it through TypoScript beforehand. I'm unsure if we should do that. This patch is pending for a year without further feedback and progress, so I'm going to abandon it for the sake of a more clean review system for now. I hope that is ok for you, the change and forge issues can always be resurrected if work continues.
  9. Christian Kuhn abandoned the change 11/09/21, 22:23