Review main Merged

65841[TASK] Drop reference index in workspace discard more effectively

Christian Kuhn CR +2 V +2 Easy +31 −1 updated 09/23/20, 20:48

Commit message

Dealing with workspace-discard, where rows are always fully
dropped in DB, the expensive reference index operation does
not need to be performed at all. It can be substituted with
straight db-delete calls for affected sys_refindex rows.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 913

  1. Christian Kuhn uploaded patch set 1 09/23/20, 16:19

  2. TYPO3com voted on patch set 1 V -1 09/23/20, 16:42 Completed build in 19m 53s on Wed, 23 Sep, 04:42 PM Test Summary: 165 of 74182 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5885

  3. Christian Kuhn commented on patch set 1 CR -1 09/23/20, 16:48

    DataHandler.php:7292 Unresolved

    todo: have workspace=this->be_user->workspace as safety net AND restriction.
  4. Christian Kuhn uploaded patch set 2 09/23/20, 16:55

  5. TYPO3com voted on patch set 2 V -1 09/23/20, 17:29 Completed build in 34m 02s on Wed, 23 Sep, 05:29 PM Test Summary: 25 of 74184 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5894

  6. Christian Kuhn uploaded patch set 3 09/23/20, 19:38

  7. TYPO3com voted on patch set 3 V +1 09/23/20, 19:50 Completed build in 11m 27s on Wed, 23 Sep, 07:50 PM Test Summary: 73691 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5902

  8. Christian Kuhn updated the commit message in patch set 4 09/23/20, 20:04

  9. Benni Mack voted on patch set 4 V +1 CR +1 09/23/20, 20:19

  10. TYPO3com voted on patch set 4 V +1 09/23/20, 20:23 Completed build in 18m 48s on Wed, 23 Sep, 08:23 PM Test Summary: 73693 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5903

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 09/23/20, 20:47

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 09/23/20, 20:48

  13. Christian Kuhn merged patch set 5 09/23/20, 20:48