Review main Merged Breaking

65842[!!!][TASK] Remove deprecated EXT:form constants and functions

Oli Bartsch CR +2 V +2 Normal +4 −81 updated 10/01/20, 09:34

Commit message

This change removes following public class constants:

* EmailFinisher::FORMAT_PLAINTEXT
* EmailFinisher::FORMAT_HTML

Following internal functions are removed:

* FormEditorController::migrateTranslationFileOptions()
* FormEditorController::migrateEmailFormatOption()

There were also some deprecated internal functions which
got already removed / changed in #90728.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1320

  1. Oli Bartsch uploaded patch set 1 09/23/20, 16:33

  2. Oli Bartsch updated the commit message in patch set 2 09/23/20, 16:33

  3. Oli Bartsch updated the commit message in patch set 3 09/23/20, 16:35

  4. Oli Bartsch updated the commit message in patch set 4 09/23/20, 16:37

  5. Oli Bartsch updated the commit message in patch set 5 09/23/20, 16:42

  6. TYPO3com voted on patch set 2 V +1 09/23/20, 16:57 Completed build in 20m 25s on Wed, 23 Sep, 04:57 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5889

  7. TYPO3com voted on patch set 1 V +1 09/23/20, 16:57 Completed build in 21m 05s on Wed, 23 Sep, 04:57 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5888

  8. TYPO3com voted on patch set 3 V +1 09/23/20, 17:05 Completed build in 28m 53s on Wed, 23 Sep, 05:05 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5890

  9. TYPO3com voted on patch set 4 V +1 09/23/20, 17:18 Completed build in 22m 47s on Wed, 23 Sep, 05:18 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5891

  10. TYPO3com voted on patch set 5 V +1 09/23/20, 17:26 Completed build in 30m 43s on Wed, 23 Sep, 05:26 PM Test Summary: 73699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5893

  11. Oli Bartsch commented on patch set 5 V -1 09/26/20, 10:31

  12. Andreas Kienast rebased onto patch set 6 09/26/20, 11:08

  13. TYPO3com voted on patch set 6 V +1 09/26/20, 11:25 Completed build in 15m 29s on Sat, 26 Sep, 11:25 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5982

  14. Oli Bartsch updated the commit message in patch set 7 09/26/20, 11:49

  15. TYPO3com voted on patch set 7 V +1 09/26/20, 12:12 Completed build in 14m 19s on Sat, 26 Sep, 12:12 PM Test Summary: 73703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5986

  16. Oliver Klee voted on patch set 7 CR +1 09/26/20, 12:28

  17. Daniel Goerz voted on patch set 7 CR +1 09/26/20, 12:36

  18. Benni Mack voted on patch set 7 V +1 CR +1 10/01/20, 09:00

  19. Daniel Goerz voted on patch set 7 V +2 CR +2 10/01/20, 09:34

  20. Daniel Goerz merged patch set 8 10/01/20, 09:34