65844[BUGFIX] Ensure view initialisation in FluidEmail
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Simon Gilli +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Simon Gilli +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1523
-
TYPO3com uploaded patch set 1 09/23/20, 22:44
-
TYPO3com voted on patch set 1 V -1 09/23/20, 22:44 Completed build in 23s on Wed, 23 Sep, 10:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5907
-
Björn Jacob updated the commit message in patch set 2 09/24/20, 05:25
-
TYPO3com voted on patch set 2 V -1 09/24/20, 05:25 Completed build in 22s on Thu, 24 Sep, 05:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5908
-
Daniel Goerz uploaded patch set 3 09/26/20, 12:33
-
TYPO3com voted on patch set 3 V +1 09/26/20, 12:44 Completed build in 10m 38s on Sat, 26 Sep, 12:44 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5988
-
Simon Gilli commented on patch set 3 CR -1 10/14/20, 14:07
My vote only concerns the changes in FileSpool.php see comments.FileSpool.php:89This is a workaround only which I've fixed in Symfony directly in the meantime see https://github.com/symfony/symfony/pull/38433FileSpool.php:99The patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/66139 solves this issue by a complete refactor to increase the readability and alsointriduces a test for this issue which is missing here. -
Anja Leichsenring commented on patch set 3 04/17/21, 07:45
is anything left here to do? I can't really follow, it has been so long, and one bugfix patch for several bugs also not so optimal. -
Simon Gilli commented on patch set 3 08/17/21, 19:36
Reply
Will rebase and check if there are any left overs to merge... -
Simon Gilli uploaded patch set 4 08/18/21, 09:59
-
Simon Gilli updated the commit message in patch set 5 08/18/21, 10:01
-
Simon Gilli updated the commit message in patch set 6 08/18/21, 10:14
-
core-ci voted on patch set 4 V +1 08/18/21, 10:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15257
-
core-ci voted on patch set 5 V -1 08/18/21, 10:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15258
-
core-ci voted on patch set 6 V +1 08/18/21, 10:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15259
-
Simon Gilli voted on patch set 6 V +1 CR +1 08/19/21, 17:34
-
Benni Mack commented on patch set 6 10/13/21, 12:29
ping -
Anja Leichsenring uploaded patch set 7 11/03/21, 13:42
-
core-ci voted on patch set 7 V +1 11/03/21, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18785
-
Simon Gilli voted on patch set 7 V +1 CR +1 11/04/21, 13:53
-
Simon Gilli commented on patch set 7 11/04/21, 13:54
Reply
DoneFileSpool.php:89ReplyDoneFileSpool.php:99ReplyDone -
Anja Leichsenring voted on patch set 7 V +2 CR +2 11/04/21, 13:55
-
Anja Leichsenring merged patch set 8 11/04/21, 13:55