Review main Merged

65847[BUGFIX] Do not use returnUrl and index.php for workspace logout links

Benni Mack CR +2 V +2 Easy +27 −16 updated 09/24/20, 16:20

Commit message

When a workspace preview is given, previously
a URL to "index.php" was set, which is not needed anymore.

Instead, the logout link for workspace preview links
should link to the current URL but only with ADMCMD_prev=LOGOUT.

The patch changes the implementation to use UriInterface
instead of string magic.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Claus-Peter Eberwein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Claus-Peter Eberwein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Benni Mack uploaded patch set 1 09/24/20, 13:25

  2. TYPO3com voted on patch set 1 V +1 09/24/20, 13:38 Completed build in 12m 08s on Thu, 24 Sep, 01:37 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5916

  3. Benni Mack uploaded patch set 2 09/24/20, 14:07

  4. Claus-Peter Eberwein voted on patch set 2 V +1 CR +1 09/24/20, 14:13

  5. TYPO3com voted on patch set 2 V +1 09/24/20, 14:19 Completed build in 12m 16s on Thu, 24 Sep, 02:19 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5917

  6. Daniel Goerz commented on patch set 2 09/24/20, 14:30

    WorkspacePreview.php:394 Unresolved

    Could we made $newAdminCommand default to empty string instead and adjust the check accordingly?
  7. Daniel Goerz uploaded patch set 3 09/24/20, 14:37

  8. Daniel Goerz voted on patch set 3 V +1 CR +1 09/24/20, 14:37

  9. TYPO3com voted on patch set 3 V +1 09/24/20, 14:48 Completed build in 11m 05s on Thu, 24 Sep, 02:48 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5918

  10. Claus-Peter Eberwein commented on patch set 3 V +1 CR +1 09/24/20, 14:56

    > Patch Set 3: Verified+1 Code-Review+1
  11. Benni Mack voted on patch set 3 V +2 CR +2 09/24/20, 16:20

  12. Benni Mack merged patch set 4 09/24/20, 16:20