Review main Merged

65849[BUGFIX] Fix copying of moved records in workspace

Benni Mack CR +2 V +2 Normal +56 −33 updated 09/25/20, 17:02

Commit message

When a moved content is copied onto another page,
the sorting is off due to not respecting move placeholders.

This is due to a limitation in PlainDataResolver which
cannot handle both liveIds and move placeholder IDs at
the same time.

For this to work, only the move placeholders are added,
and the respective live ids are kept.

The tests show that the previous behavior is wrong,
as the ordering should be
- Regular Element 2
- Regular Element 1
- Regular Element 3
on the newly created draft page 91.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Claus-Peter Eberwein +1
    • David Steeb +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Claus-Peter Eberwein +1
    • David Steeb +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 913

  1. Benni Mack uploaded patch set 1 09/24/20, 16:16

  2. TYPO3com voted on patch set 1 V -1 09/24/20, 16:28 Completed build in 12m 14s on Thu, 24 Sep, 04:28 PM Test Summary: 4 of 74190 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5921

  3. Benni Mack uploaded patch set 2 09/25/20, 14:08

  4. TYPO3com voted on patch set 2 V +1 09/25/20, 14:20 Completed build in 12m 13s on Fri, 25 Sep, 02:20 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5947

  5. Benni Mack updated the commit message in patch set 3 09/25/20, 15:11

  6. TYPO3com voted on patch set 3 V -1 09/25/20, 15:30 Completed build in 11m 56s on Fri, 25 Sep, 03:30 PM Test Summary: 11 of 74190 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5954

  7. TYPO3com voted on patch set 3 V +1 09/25/20, 15:35 Completed build in 29m 38s on Fri, 25 Sep, 03:35 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5954

  8. Oliver Hader voted on patch set 3 CR +1 09/25/20, 15:50

  9. Oliver Hader commented on patch set 3 V +1 09/25/20, 16:04

    Nice! Tested in TYPO3 v10 as well
  10. Claus-Peter Eberwein voted on patch set 3 V +1 CR +1 09/25/20, 16:23

  11. David Steeb voted on patch set 3 V +1 CR +1 09/25/20, 16:23

  12. Benni Mack voted on patch set 3 V +2 CR +2 09/25/20, 17:02

  13. Benni Mack merged patch set 4 09/25/20, 17:02