65850[TASK] Activate phpstan rule IncompatiblePhpDocTypeRule
Commit message
Review
-
Code review CR +2 Done
- Alexander Schnitzler +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Alexander Schnitzler +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 6
- Build/phpstan.level2.neon+1 −1
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+4 −5
- typo3/sysext/core/Classes/Imaging/ImageManipulation/CropVariant.php+2 −2
- typo3/sysext/core/Classes/Imaging/ImageManipulation/CropVariantCollection.php+1 −1
- typo3/sysext/core/Classes/Resource/Search/Result/DriverFilteredSearchResult.php+2 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −1
Review log 1113
-
Daniel Goerz uploaded patch set 1 09/25/20, 07:54
-
Daniel Goerz commented on patch set 1 CR -1 09/25/20, 07:55
v10 must be synced with master first in terms of phpstan version and neon files -
TYPO3com voted on patch set 1 V +1 09/25/20, 08:05 Completed build in 11m 08s on Fri, 25 Sep, 08:05 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5926
-
Oliver Klee voted on patch set 1 CR +1 09/25/20, 09:14
-
Daniel Goerz commented on patch set 1 09/25/20, 09:19
-
Daniel Goerz voted on patch set 1 CR 0 09/25/20, 09:51
-
Daniel Goerz rebased onto patch set 2 09/25/20, 09:51
-
Oliver Klee voted on patch set 2 CR +1 09/25/20, 09:55
-
TYPO3com voted on patch set 2 V +1 09/25/20, 10:06 Completed build in 13m 23s on Fri, 25 Sep, 10:06 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5933
-
Andreas Kienast voted on patch set 2 V +1 CR +1 09/25/20, 10:06
-
Alexander Schnitzler voted on patch set 2 V +1 CR +1 09/25/20, 10:09
-
Alexander Schnitzler voted on patch set 2 V +2 CR +2 09/25/20, 10:10
-
Alexander Schnitzler merged patch set 3 09/25/20, 10:10