Review main Merged

65850[TASK] Activate phpstan rule IncompatiblePhpDocTypeRule

Daniel Goerz CR +2 V +2 Easy +11 −12 updated 09/25/20, 10:10

Commit message

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1113

  1. Daniel Goerz uploaded patch set 1 09/25/20, 07:54

  2. Daniel Goerz commented on patch set 1 CR -1 09/25/20, 07:55

    v10 must be synced with master first in terms of phpstan version and neon files
  3. TYPO3com voted on patch set 1 V +1 09/25/20, 08:05 Completed build in 11m 08s on Fri, 25 Sep, 08:05 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5926

  4. Oliver Klee voted on patch set 1 CR +1 09/25/20, 09:14

  5. Daniel Goerz commented on patch set 1 09/25/20, 09:19

  6. Daniel Goerz voted on patch set 1 CR 0 09/25/20, 09:51

  7. Daniel Goerz rebased onto patch set 2 09/25/20, 09:51

  8. Oliver Klee voted on patch set 2 CR +1 09/25/20, 09:55

  9. TYPO3com voted on patch set 2 V +1 09/25/20, 10:06 Completed build in 13m 23s on Fri, 25 Sep, 10:06 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5933

  10. Andreas Kienast voted on patch set 2 V +1 CR +1 09/25/20, 10:06

  11. Alexander Schnitzler voted on patch set 2 V +1 CR +1 09/25/20, 10:09

  12. Alexander Schnitzler voted on patch set 2 V +2 CR +2 09/25/20, 10:10

  13. Alexander Schnitzler merged patch set 3 09/25/20, 10:10