Review main Merged

65851[TASK] Update phpstan/phpstan and friendsoftypo3/phpstan-typo3

Alexander Schnitzler CR +2 V +2 Easy +22 −21 updated 09/25/20, 09:50

Commit message

Used commands:

    - composer require phpstan/phpstan:^0.12.44 --dev
    - composer require friendsoftypo3/phpstan-typo3:^0.5.0 --dev

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 913

  1. Alexander Schnitzler uploaded patch set 1 09/25/20, 09:09

  2. Alexander Schnitzler commented on patch set 1 09/25/20, 09:09

    This change is ready for review.
  3. Oliver Klee voted on patch set 1 CR +1 09/25/20, 09:12

  4. Alexander Schnitzler uploaded patch set 2 09/25/20, 09:16

  5. Daniel Goerz voted on patch set 2 V +1 CR +1 09/25/20, 09:18

  6. Alexander Schnitzler voted on patch set 2 V +1 CR +1 09/25/20, 09:18

  7. Alexander Schnitzler wrote 09/25/20, 09:18

    Topic set to phpstan
  8. TYPO3com voted on patch set 1 V -1 09/25/20, 09:21 Completed build in 11m 49s on Fri, 25 Sep, 09:21 AM Test Summary: 70753 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5929

  9. TYPO3com voted on patch set 2 V -1 09/25/20, 09:28 Completed build in 12m 03s on Fri, 25 Sep, 09:28 AM Test Summary: 71578 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5930

  10. TYPO3com commented on patch set 2 09/25/20, 09:40 Completed build in 36m 13s on Fri, 25 Sep, 09:40 AM Test Summary: 18 of 74190 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5930

  11. TYPO3com voted on patch set 2 V +1 09/25/20, 09:45 Completed build in 1h 05m 51s on Fri, 25 Sep, 09:45 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5930

  12. Daniel Goerz voted on patch set 2 V +2 CR +2 09/25/20, 09:50

  13. Daniel Goerz merged patch set 3 09/25/20, 09:50