Review 10.4 Merged

65854[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Page

Christian Kuhn CR +2 V +2 Easy +13 −8 updated 09/23/20, 21:25

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 09/23/20, 20:55

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/23/20, 21:13 Completed build in 13m 23s on Wed, 23 Sep, 09:13 PM Test Summary: 74737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-479

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 09/23/20, 21:25

  4. Christian Kuhn merged patch set 2 09/23/20, 21:25