Review 10.4 Merged

65855[BUGFIX] Remove wrongly introduced showNewRecordLink property

Benni Mack CR +2 V +2 Easy +5 −10 updated 09/24/20, 15:25

Commit message

With #82489 a condition, introduced in #71918, was changed as
it misused the `['appearance']['enabledControls']['new']` property
to hide the newRecordLink button while actually only the "new" button
of inline records controls should be hidden.

To provide the possibility to hide the newRecordLink, independent
of the controls, a new property `showNewRecordLink` was introduced.

This new property is however superfluous as the newRecordLink button
can already be hidden by setting `['appearance']['levelLinksPosition']`
to `none`.

Therefore the newly introduced `showNewRecordLink` property along
with the condition is removed and the RST is updated and moved to
the correct directory.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 710

  1. Benni Mack commented on patch set 1 09/24/20, 13:52

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php
  2. TYPO3com voted on patch set 1 V -1 09/24/20, 13:52 Completed build in 24s on Thu, 24 Sep, 01:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-483

  3. Oli Bartsch uploaded patch set 2 09/24/20, 14:01

  4. TYPO3com voted on patch set 2 V +1 09/24/20, 14:13 Completed build in 11m 51s on Thu, 24 Sep, 02:13 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-484

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 09/24/20, 14:13

  6. Benni Mack commented on patch set 2 09/24/20, 14:20

    This change is ready for review.
  7. Oli Bartsch uploaded patch set 3 09/24/20, 14:50

  8. TYPO3com voted on patch set 3 V +1 09/24/20, 15:03 Completed build in 12m 50s on Thu, 24 Sep, 03:03 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-485

  9. Benni Mack voted on patch set 3 V +2 CR +2 09/24/20, 15:24

  10. Benni Mack merged patch set 4 09/24/20, 15:25