Review 10.4 Merged

65856[BUGFIX] Do not use returnUrl and index.php for workspace logout links

Benni Mack CR +2 V +2 Easy +27 −16 updated 09/25/20, 07:19

Commit message

When a workspace preview is given, previously
a URL to "index.php" was set, which is not needed anymore.

Instead, the logout link for workspace preview links
should link to the current URL but only with ADMCMD_prev=LOGOUT.

The patch changes the implementation to use UriInterface
instead of string magic.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 09/24/20, 16:20

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php
  2. TYPO3com voted on patch set 1 V -1 09/24/20, 16:21 Completed build in 30s on Thu, 24 Sep, 04:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-486

  3. Benni Mack commented on patch set 2 09/24/20, 16:21

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 2 09/24/20, 16:21

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 09/24/20, 16:33 Completed build in 11m 56s on Thu, 24 Sep, 04:33 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-487

  6. Benni Mack voted on patch set 2 V +2 CR +2 09/25/20, 07:19

  7. Benni Mack merged patch set 3 09/25/20, 07:19