Review 10.4 Merged

65857[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Cache

Daniel Goerz CR +2 V +2 Easy +20 −15 updated 09/25/20, 10:38

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 45

  1. Daniel Goerz commented on patch set 1 09/25/20, 10:09

    Cherry Picked from branch master.
  2. Oliver Klee voted on patch set 1 CR +1 09/25/20, 10:11

  3. TYPO3com voted on patch set 1 V +1 09/25/20, 10:22 Completed build in 12m 40s on Fri, 25 Sep, 10:22 AM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-492

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 09/25/20, 10:38

  5. Daniel Goerz merged patch set 2 09/25/20, 10:38