65862[BUGFIX] Render plugin content element only if a plugin is selected
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
-
Verified V +2 Done
- Daniel Goerz +2
- TYPO3com +1 CI
Issues 1
Files 1
Review log 67
-
Daniel Goerz commented on patch set 1 09/26/20, 11:34
Cherry Picked from branch master. -
TYPO3com voted on patch set 1 V +1 09/26/20, 11:55 Completed build in 17m 57s on Sat, 26 Sep, 11:55 AM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-513
-
Daniel Goerz voted on patch set 1 V +2 CR +2 09/26/20, 11:58
-
Daniel Goerz merged patch set 2 09/26/20, 11:58
-
Simon Schaufelberger commented on patch set 2 09/29/20, 11:20
Would it not also make sense to show an error message that no plugin was selected? -
Torben Hansen commented on patch set 2 09/29/20, 11:34
> Patch Set 2: > > Would it not also make sense to show an error message that no plugin was selected? The problem is a misconfiguration the editor made, so there is IMO no need to show an error message in the frontend to all users of the website. I think it would be better to show a warning in the backend for the affected Content Element (e.g. "Plugin misconfigured"). -
Daniel Goerz commented on patch set 2 09/29/20, 13:05
> Patch Set 2: > > > Patch Set 2: > > > > Would it not also make sense to show an error message that no plugin was selected? > > The problem is a misconfiguration the editor made, so there is IMO no need to show an error message in the frontend to all users of the website. I think it would be better to show a warning in the backend for the affected Content Element (e.g. "Plugin misconfigured"). I think it would be a reasonable feature to show a warning in the page module if a plugin (aka "list) CE is stored without a plugin selected (aka "list_type"). Please go ahead and open a feature request for this @ forge.