Review 10.4 Merged

65864[TASK] Remove Build/phpstan.level2.neon

Alexander Schnitzler CR +2 V +2 Normal +7 −60 updated 09/26/20, 18:00

Commit message

Since all level 2 rules are active and only level 2
parameters are set to different values compared to
their originally declared value, the whole file can
be removed, the overall phpstan level can be raised
to 2 and the parameters can be defined in the main
phpstan file.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Alexander Schnitzler commented on patch set 1 09/26/20, 16:37

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/26/20, 16:49 Completed build in 11m 14s on Sat, 26 Sep, 04:49 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-520

  3. Alexander Schnitzler commented on patch set 1 09/26/20, 16:52

    I am not sure about the commit message. We have to remove everything up to "Reviewed on"?
  4. Daniel Goerz updated the commit message in patch set 2 09/26/20, 17:02

  5. Daniel Goerz commented on patch set 2 09/26/20, 17:03

    > Patch Set 1: > > I am not sure about the commit message. We have to remove everything up to "Reviewed on"? yes :)
  6. TYPO3com voted on patch set 2 V +1 09/26/20, 17:16 Completed build in 12m 44s on Sat, 26 Sep, 05:16 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-521

  7. Alexander Schnitzler voted on patch set 2 V +2 CR +2 09/26/20, 17:17

  8. Oliver Klee voted on patch set 2 CR +1 09/26/20, 17:20

  9. Daniel Goerz voted on patch set 2 V +2 CR +2 09/26/20, 18:00

  10. Daniel Goerz merged patch set 3 09/26/20, 18:00