Review 10.4 Merged

65865[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:redirects

Daniel Goerz CR +2 V +2 Easy +6 −3 updated 09/27/20, 13:51

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 34

  1. Daniel Goerz commented on patch set 1 09/27/20, 13:10

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/27/20, 13:32 Completed build in 17m 49s on Sun, 27 Sep, 01:32 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-525

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 09/27/20, 13:51

  4. Daniel Goerz merged patch set 2 09/27/20, 13:51