Review 10.4 Merged

65868[TASK] Fix phpstan checkFunctionArgumentTypes errors in several extensions

Andreas Kienast CR +2 V +2 Easy +17 −16 updated 09/27/20, 14:55

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 6

Files 8

Review log 35

  1. Andreas Kienast commented on patch set 1 09/27/20, 14:21

    Cherry Picked from branch master.
  2. Andreas Kienast voted on patch set 1 V +2 CR +2 09/27/20, 14:22

  3. TYPO3com voted on patch set 1 V -1 09/27/20, 14:47 Completed build in 18m 05s on Sun, 27 Sep, 02:47 PM Test Summary: 1 of 75234 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-530

  4. TYPO3com voted on patch set 1 V +1 09/27/20, 14:54 Completed build in 43m 20s on Sun, 27 Sep, 02:54 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-530

  5. Andreas Kienast merged patch set 2 09/27/20, 14:55