Review 10.4 Merged

65870[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:belog

Daniel Goerz CR +2 V +2 Easy +10 −10 updated 09/27/20, 15:27

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1

Issues 1

Files 4

Review log 56

  1. Daniel Goerz commented on patch set 1 09/27/20, 14:56

    Cherry Picked from branch master.
  2. Andreas Kienast voted on patch set 1 V +1 CR +1 09/27/20, 14:59

  3. Oliver Klee voted on patch set 1 CR +1 09/27/20, 15:00

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 09/27/20, 15:02

  5. Daniel Goerz merged patch set 2 09/27/20, 15:02

  6. TYPO3com voted on patch set 1 V +1 09/27/20, 15:27 Completed build in 24m 31s on Sun, 27 Sep, 03:27 PM Test Summary: 74748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-535