Review main Merged

65876[BUGFIX] Proper reference index updating on workspace publish

Christian Kuhn CR +2 V +2 Hard +221 −142 updated 10/02/20, 18:31

Commit message

Yet another reference index bugfix: On workspace publish,
reference index is not properly triggered as already noted
in some of the .csv test files.
The patch moves some of the recently added methods from
DataHandler to ReferenceIndexUpdater and handles cases like
publish correctly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 50

Show 30 more files

Review log 1220

  1. Christian Kuhn uploaded patch set 1 09/25/20, 12:11

  2. TYPO3com voted on patch set 1 V -1 09/25/20, 12:24 Completed build in 13m 26s on Fri, 25 Sep, 12:24 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5939

  3. Christian Kuhn uploaded patch set 2 09/25/20, 12:55

  4. TYPO3com voted on patch set 2 V +1 09/25/20, 13:07 Completed build in 11m 49s on Fri, 25 Sep, 01:07 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5943

  5. Christian Kuhn uploaded patch set 3 09/25/20, 13:42

  6. TYPO3com voted on patch set 3 V -1 09/25/20, 13:43 Completed build in 25s on Fri, 25 Sep, 01:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5945

  7. Christian Kuhn uploaded patch set 4 09/25/20, 13:46

  8. Christian Kuhn commented on patch set 3 09/25/20, 13:46

    ReferenceIndexUpdater.php:93 Unresolved

    Currently not sure if we really need $targetWorkspace ... we'll see. I may drop that in younger patch sets again.
  9. TYPO3com voted on patch set 4 V -1 09/25/20, 14:03 Completed build in 16m 41s on Fri, 25 Sep, 02:03 PM Test Summary: 138 of 74166 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5946

  10. Christian Kuhn uploaded patch set 5 10/02/20, 10:02

  11. TYPO3com voted on patch set 5 V -1 10/02/20, 10:17 Completed build in 14m 57s on Fri, 2 Oct, 10:17 AM Test Summary: 138 of 74175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6158

  12. Christian Kuhn uploaded patch set 6 10/02/20, 14:11

  13. TYPO3com voted on patch set 6 V -1 10/02/20, 15:00 Completed build in 38m 18s on Fri, 2 Oct, 03:00 PM Test Summary: 3 of 74199 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6193

  14. Christian Kuhn uploaded patch set 7 10/02/20, 15:03

  15. TYPO3com voted on patch set 7 V -1 10/02/20, 15:59 Completed build in 34m 39s on Fri, 2 Oct, 03:59 PM Test Summary: 73735 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6204

  16. TYPO3com voted on patch set 7 V +1 10/02/20, 16:10 Completed build in 1h 20m 38s on Fri, 2 Oct, 04:10 PM Test Summary: 73735 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6204

  17. Anja Leichsenring voted on patch set 7 V +1 CR +1 10/02/20, 16:27

  18. Oli Bartsch voted on patch set 7 V +1 CR +1 10/02/20, 17:37

  19. Christian Kuhn voted on patch set 7 V +2 CR +2 10/02/20, 18:31

  20. Christian Kuhn merged patch set 8 10/02/20, 18:31