Review main Merged

65882[BUGFIX] Render plugin content element only if a plugin is selected

Torben Hansen CR +2 V +2 Easy +3 −1 updated 09/26/20, 11:33

Commit message

This patch ensures, that the plugin content element only calls the
f:cObject viewHelper, when a plugin is selected in the list of
available plugins.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Guido Schmechel +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Torben Hansen uploaded patch set 1 09/25/20, 14:23

  2. Andreas Kienast voted on patch set 1 CR +1 09/25/20, 14:35

  3. TYPO3com voted on patch set 1 V +1 09/25/20, 14:45 Completed build in 19m 25s on Fri, 25 Sep, 02:45 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5950

  4. Georg Ringer voted on patch set 1 V +1 CR +1 09/25/20, 17:54

  5. Guido Schmechel voted on patch set 1 CR +1 09/25/20, 19:57

  6. Oli Bartsch commented on patch set 1 V +1 CR +1 09/25/20, 20:14

    The patch is reasonable however does it make sense to add CType=is
  7. Daniel Goerz voted on patch set 1 V +2 CR +2 09/26/20, 11:33

  8. Daniel Goerz merged patch set 2 09/26/20, 11:33