65888[BUGFIX] Set property hreflang of SiteLanguage to empty string
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Guido Schmechel +1
- Martin Kutschker +1
- Richard Haeser +1
-
Verified V +2 Done
- Georg Ringer +2
- Martin Kutschker +1
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Site/Entity/SiteLanguage.php+1 −1
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteLanguageTest.php+1 −1
- typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php+1 −1
- typo3/sysext/seo/Tests/Functional/Fixtures/HrefLangScenario.yml+2 −0
- typo3/sysext/seo/Tests/Functional/HrefLang/HrefLangGeneratorTest.php+26 −0
Review log 1622
-
Georg Ringer uploaded patch set 1 09/25/20, 19:05
-
Georg Ringer commented on patch set 1 09/25/20, 19:05
This change is ready for review. -
Georg Ringer wrote 09/25/20, 19:10
Topic set to sitelanguage -
TYPO3com voted on patch set 1 V -1 09/25/20, 19:17 Completed build in 11m 45s on Fri, 25 Sep, 07:17 PM Test Summary: 1 of 74190 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5957
-
Georg Ringer rebased onto patch set 2 09/29/20, 16:41
-
TYPO3com voted on patch set 2 V +1 09/29/20, 16:57 Completed build in 15m 48s on Tue, 29 Sep, 04:57 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6070
-
Oliver Klee voted on patch set 2 CR +1 09/29/20, 16:57
-
Georg Ringer rebased onto patch set 3 10/06/20, 19:10
-
TYPO3com voted on patch set 3 V -1 10/06/20, 19:26 Completed build in 15m 25s on Tue, 6 Oct, 07:26 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6300
-
Georg Ringer rebased onto patch set 4 10/07/20, 08:21
-
TYPO3com voted on patch set 4 V +1 10/07/20, 08:41 Completed build in 19m 03s on Wed, 7 Oct, 08:41 AM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6309
-
Richard Haeser commented on patch set 4 12/27/20, 13:00
Should we target 10 branch as well? -
Richard Haeser voted on patch set 4 V +1 CR +1 12/27/20, 13:47
-
Richard Haeser rebased onto patch set 5 12/27/20, 14:05
-
Richard Haeser uploaded patch set 6 12/27/20, 14:06
-
Richard Haeser commented on patch set 6 V +1 CR +1 12/27/20, 14:07
Added some more functional tests -
TYPO3com voted on patch set 5 V +1 12/27/20, 14:15 Completed build in 09m 25s on Sun, 27 Dec, 02:15 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8465
-
TYPO3com voted on patch set 6 V +1 12/27/20, 14:17 Completed build in 11m 17s on Sun, 27 Dec, 02:17 PM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8466
-
Guido Schmechel voted on patch set 6 CR +1 01/02/21, 11:54
-
Martin Kutschker voted on patch set 6 V +1 CR +1 01/03/21, 11:19
-
Georg Ringer voted on patch set 6 V +2 CR +2 01/03/21, 12:04
-
Georg Ringer merged patch set 7 01/03/21, 12:04