Review main Merged

65888[BUGFIX] Set property hreflang of SiteLanguage to empty string

Georg Ringer CR +2 V +2 Easy +31 −3 updated 01/03/21, 12:04

Commit message

By defining `$hreflang` of SiteLanguage to an empty string instead of
'en-US' wrong hreflang tags are avoided in the frontend.

Even though the field is set to required there are usecases where this
field is not set, e.g. by changing the site configuration manually. This
would have lead to hreflang tags pointing to a valid site but with a
wrong hreflang information.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Martin Kutschker +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Martin Kutschker +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1622

  1. Georg Ringer uploaded patch set 1 09/25/20, 19:05

  2. Georg Ringer commented on patch set 1 09/25/20, 19:05

    This change is ready for review.
  3. Georg Ringer wrote 09/25/20, 19:10

    Topic set to sitelanguage
  4. TYPO3com voted on patch set 1 V -1 09/25/20, 19:17 Completed build in 11m 45s on Fri, 25 Sep, 07:17 PM Test Summary: 1 of 74190 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5957

  5. Georg Ringer rebased onto patch set 2 09/29/20, 16:41

  6. TYPO3com voted on patch set 2 V +1 09/29/20, 16:57 Completed build in 15m 48s on Tue, 29 Sep, 04:57 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6070

  7. Oliver Klee voted on patch set 2 CR +1 09/29/20, 16:57

  8. Georg Ringer rebased onto patch set 3 10/06/20, 19:10

  9. TYPO3com voted on patch set 3 V -1 10/06/20, 19:26 Completed build in 15m 25s on Tue, 6 Oct, 07:26 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6300

  10. Georg Ringer rebased onto patch set 4 10/07/20, 08:21

  11. TYPO3com voted on patch set 4 V +1 10/07/20, 08:41 Completed build in 19m 03s on Wed, 7 Oct, 08:41 AM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6309

  12. Richard Haeser commented on patch set 4 12/27/20, 13:00

    Should we target 10 branch as well?
  13. Richard Haeser voted on patch set 4 V +1 CR +1 12/27/20, 13:47

  14. Richard Haeser rebased onto patch set 5 12/27/20, 14:05

  15. Richard Haeser uploaded patch set 6 12/27/20, 14:06

  16. Richard Haeser commented on patch set 6 V +1 CR +1 12/27/20, 14:07

    Added some more functional tests
  17. TYPO3com voted on patch set 5 V +1 12/27/20, 14:15 Completed build in 09m 25s on Sun, 27 Dec, 02:15 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8465

  18. TYPO3com voted on patch set 6 V +1 12/27/20, 14:17 Completed build in 11m 17s on Sun, 27 Dec, 02:17 PM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8466

  19. Guido Schmechel voted on patch set 6 CR +1 01/02/21, 11:54

  20. Martin Kutschker voted on patch set 6 V +1 CR +1 01/03/21, 11:19

  21. Georg Ringer voted on patch set 6 V +2 CR +2 01/03/21, 12:04

  22. Georg Ringer merged patch set 7 01/03/21, 12:04