65892[TASK] Show name of table when editing record
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+9 −0
- typo3/sysext/backend/Classes/Form/Container/OuterWrapContainer.php4+1 −0
- typo3/sysext/backend/Resources/Private/Templates/OuterWrapContainer.html+3 −0
- typo3/sysext/core/Classes/Resource/Service/UserFileInlineLabelService.php+13 −3
Review log 3147
Show 1422 earlier messages
-
Georg Ringer uploaded patch set 1 09/25/20, 19:50
-
TYPO3com voted on patch set 1 V -1 09/25/20, 19:51 Completed build in 24s on Fri, 25 Sep, 07:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5963
-
Daniel Siepmann uploaded patch set 2 09/28/20, 06:21
-
Georg Ringer commented on patch set 2 CR -1 09/28/20, 06:32
- now only the outer table name is shown but especially for IRRE, this fature is useful as well as - the debug info for fieldnames is only shown if debug is enabled AND current user is an admin -
TYPO3com voted on patch set 2 V +1 09/28/20, 06:34 Completed build in 12m 49s on Mon, 28 Sep, 06:34 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6032
-
Daniel Siepmann commented on patch set 2 09/28/20, 06:37
> Patch Set 2: Code-Review-1 > > - now only the outer table name is shown but especially for IRRE, this fature is useful as well as > - the debug info for fieldnames is only shown if debug is enabled AND current user is an admin Fair point. I would suggest to adjust the rendering for IRRE and add the same info in the same way as for the outer table. I don't get why only admins would see the info. What am I missing? -
Georg Ringer uploaded patch set 3 09/28/20, 21:24
-
TYPO3com voted on patch set 3 V -1 09/28/20, 21:29 Completed build in 50s on Mon, 28 Sep, 09:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6054
-
Daniel Siepmann uploaded patch set 4 09/29/20, 06:13
-
TYPO3com voted on patch set 4 V -1 09/29/20, 06:14 Completed build in 24s on Tue, 29 Sep, 06:14 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6058
-
Daniel Siepmann uploaded patch set 5 09/29/20, 06:16
-
TYPO3com voted on patch set 5 V -1 09/29/20, 06:17 Completed build in 21s on Tue, 29 Sep, 06:17 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6059
-
Daniel Siepmann uploaded patch set 6 09/29/20, 06:46
-
TYPO3com voted on patch set 6 V -1 09/29/20, 06:58 Completed build in 11m 33s on Tue, 29 Sep, 06:58 AM Test Summary: 4 of 74190 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6060
-
Georg Ringer uploaded patch set 7 10/06/20, 19:52
-
Georg Ringer commented on patch set 7 10/06/20, 19:53
@Daniel: I reverted all changes which shouldn't be part of this patch -
TYPO3com voted on patch set 7 V -1 10/06/20, 20:05 Completed build in 13m 46s on Tue, 6 Oct, 08:05 PM Test Summary: 4 of 74270 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6301
-
Benni Mack rebased onto patch set 8 09/01/21, 09:49
-
core-ci voted on patch set 8 V -1 09/01/21, 10:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16003
-
Tymoteusz Motylewski commented on patch set 8 09/02/21, 13:27
> Patch Set 8: Verified-1 > > Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16003 The failure is real, test needs to be adapted -> to assert changed name, or limit the assertion just to element name (without table) -
Benni Mack commented on patch set 8 10/08/21, 08:28
I consider not making this a feature but a bugfix instead, since this is also part of the "show field names" feature added by you. -
Georg Ringer rebased onto patch set 9 10/09/21, 07:35
-
core-ci voted on patch set 9 V -1 10/09/21, 07:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17858
-
Georg Ringer uploaded patch set 10 10/09/21, 08:30
-
core-ci voted on patch set 10 V -1 10/09/21, 08:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17859
-
Georg Ringer uploaded patch set 11 10/09/21, 08:36
-
core-ci voted on patch set 11 V -1 10/09/21, 09:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17860
-
Nikita Hovratov uploaded patch set 12 10/09/21, 15:18
-
core-ci voted on patch set 12 V +1 10/09/21, 15:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17874
-
Guido Schmechel commented on patch set 12 10/09/21, 16:18
Basically, it runs in the backend. Good idea :-)OuterWrapContainer.php:146If I see it correctly you could use the $table variable from line 45 here? -
Georg Ringer uploaded patch set 13 10/10/21, 06:36
-
core-ci voted on patch set 13 V +1 10/10/21, 06:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17884
-
Stefan Bürk voted on patch set 13 V +1 CR +1 10/11/21, 09:24
-
Oli Bartsch commented on patch set 13 CR -1 10/11/21, 10:56
_main_form.scss:600This variable seems to not belong here.AbstractContainer.php:143Actually, this looks more like a list. We might use the corresponding tags instead of manually breaking lines?AbstractContainer.php:147Creating a new inline record, this displays the parent page id. Besides, I don't know if we should add this information at all. The UID is already available on the record type icon.OuterWrapContainer.php:140I think we don't need this additional flag. We could just set "tableName" accordingly: 'tableName' => ($GLOBALS['TYPO3_CONF_VARS']['BE']['debug'] ?? false) && $backendUser->isAdmin() ? $table : '' -
Georg Ringer uploaded patch set 14 10/11/21, 19:23
-
core-ci voted on patch set 14 V -1 10/11/21, 19:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17935
-
Nikita Hovratov uploaded patch set 15 10/12/21, 08:18
-
Nikita Hovratov commented on patch set 15 10/12/21, 08:21
_main_form.scss:600ReplyDoneAbstractContainer.php:143ReplyDoneAbstractContainer.php:147ReplyDoneOuterWrapContainer.php:140ReplyDoneOuterWrapContainer.php:146ReplyDone -
Nikita Hovratov voted on patch set 15 V +1 CR +1 10/12/21, 08:23
-
Oli Bartsch commented on patch set 15 CR -1 10/12/21, 08:30
On it -
core-ci voted on patch set 15 V +1 10/12/21, 08:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17949
-
Oli Bartsch uploaded patch set 16 10/12/21, 09:13
-
Oli Bartsch voted on patch set 16 V +1 CR +1 10/12/21, 09:15
-
Nikita Hovratov voted on patch set 16 V +1 CR +1 10/12/21, 09:27
-
core-ci voted on patch set 16 V +1 10/12/21, 09:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17953
-
Georg Ringer voted on patch set 16 V +2 CR +2 10/12/21, 09:32
-
Georg Ringer merged patch set 17 10/12/21, 09:32