Review main Merged

65899[FEATURE] Use the ckeditor plugin editorplaceholder

Georg Ringer CR +2 V +2 Easy +42 −0 updated 09/26/20, 08:14

Commit message

Enable the ckeditor plugin editorplaceholder which is available since
the update of ckeditor to version 4.15.0 with #92412 and fill it with
the placeholder information provided by the TCA.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Torben Hansen +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1216

  1. Georg Ringer uploaded patch set 1 09/25/20, 20:48

  2. Georg Ringer commented on patch set 1 09/25/20, 20:49

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 09/25/20, 21:22 Completed build in 17m 56s on Fri, 25 Sep, 09:22 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5968

  4. Oli Bartsch uploaded patch set 2 09/25/20, 22:01

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 09/25/20, 22:02

  6. TYPO3com voted on patch set 2 V +1 09/25/20, 22:22 Completed build in 20m 57s on Fri, 25 Sep, 10:22 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5971

  7. Oli Bartsch commented on patch set 3 09/25/20, 23:04

    Published edit on patch set 2.
  8. Oli Bartsch voted on patch set 3 V +1 CR +1 09/25/20, 23:04

  9. TYPO3com voted on patch set 3 V +1 09/25/20, 23:17 Completed build in 13m 12s on Fri, 25 Sep, 11:17 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5972

  10. Josef Glatz commented on patch set 3 V -1 09/26/20, 05:42

    What about the Full preset?
  11. Torben Hansen uploaded patch set 4 09/26/20, 05:44

  12. Torben Hansen commented on patch set 4 V +1 CR +1 09/26/20, 05:45

    We should also enable the plugin for the "Full.yaml" configuration of ckeditor
  13. TYPO3com voted on patch set 4 V +1 09/26/20, 05:58 Completed build in 13m 36s on Sat, 26 Sep, 05:58 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5973

  14. Oli Bartsch commented on patch set 4 V +1 CR +1 09/26/20, 07:18

    > Patch Set 3: Verified-1 > > What about the Full preset?
  15. Andreas Kienast voted on patch set 4 V +2 CR +2 09/26/20, 08:14

  16. Andreas Kienast merged patch set 5 09/26/20, 08:14