Review 10.4 Merged

65901[FEATURE] Add FluidEmail option to EXT:form EmailFinisher

Oli Bartsch CR +2 V +2 Hard +338 −34 updated 01/18/21, 19:06

Commit message

EXT:form, the last system extension not using FluidEmail
was extended for the corresponing integration. To allow
extension authors to smoothly test and upgrade, the old
StandaloneView functionality remains for now.

As there is no change to the present behaviour the switch
can be done without further actions required - if using the
default templates currently.

To migrate custom templates to FluidEmail, the template files
must be changed from the {@format}.html syntax to appropriate
names with the correct format extension like `.html` and `.txt`.
Furthermore the `templateName` option must be set with the new name.

Two fields are introduced to configure FluidEmail in the finishers:

- `useFluidEmail`: Enables sending the mails via FluidEmail
- `title`: Used for the title section of the default template

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 1420

  1. Oli Bartsch uploaded patch set 1 09/26/20, 14:56

  2. Oli Bartsch uploaded patch set 2 09/26/20, 15:05

  3. Oli Bartsch uploaded patch set 3 09/26/20, 15:09

  4. TYPO3com voted on patch set 1 V +1 09/26/20, 15:09 Completed build in 13m 03s on Sat, 26 Sep, 03:09 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-516

  5. TYPO3com voted on patch set 2 V +1 09/26/20, 15:17 Completed build in 12m 17s on Sat, 26 Sep, 03:17 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-517

  6. TYPO3com voted on patch set 3 V -1 09/26/20, 15:22 Completed build in 12m 47s on Sat, 26 Sep, 03:22 PM Test Summary: 1 of 75234 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-518

  7. Oli Bartsch uploaded patch set 4 09/26/20, 16:14

  8. TYPO3com voted on patch set 4 V +1 09/26/20, 16:26 Completed build in 12m 05s on Sat, 26 Sep, 04:26 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-519

  9. Benni Mack commented on patch set 4 09/28/20, 08:44

    Database.xlf:153

    tabs, everything else is indented with spaces.
  10. Oli Bartsch uploaded patch set 5 09/28/20, 09:04

  11. Oli Bartsch uploaded patch set 6 09/28/20, 09:06

  12. Oli Bartsch commented on patch set 6 09/28/20, 09:07

    > Patch Set 4: > > (1 comment)

    Database.xlf:153 Reply

    Done
  13. TYPO3com voted on patch set 5 V +1 09/28/20, 09:18 Completed build in 13m 25s on Mon, 28 Sep, 09:18 AM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-540

  14. TYPO3com voted on patch set 6 V +1 09/28/20, 09:21 Completed build in 12m 53s on Mon, 28 Sep, 09:20 AM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-541

  15. Daniel Goerz commented on patch set 6 V +1 CR +1 09/28/20, 13:13

    Both ways of sending mails via finisher still work
  16. Benni Mack voted on patch set 6 V +2 CR +2 09/29/20, 04:57

  17. Benni Mack merged patch set 7 09/29/20, 04:57

  18. Martin Kutschker commented on patch set 7 01/18/21, 14:16

    The RST is wrong.

    Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:29

    None of the Fluid root pathes are used in the code.

    Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:51

    addHtmlPart has no effect when usig FluidEmail.
  19. Oli Bartsch commented on patch set 7 01/18/21, 15:56

    Reply

    Tested it again and everything still works as advertised.

    Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:29 Reply

    Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:51 Reply

  20. Martin Kutschker commented on patch set 7 01/18/21, 19:06

    All is well, sorry for false alarm.

    Reply

    Ack

    Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:29 Reply

    I goofed, it's in the initialzing method.

    Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:51 Reply

    Ack