65901[FEATURE] Add FluidEmail option to EXT:form EmailFinisher
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/Mail/FluidEmail.php+10 −0
- typo3/sysext/core/Documentation/Changelog/10.4.x/Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst6new+67 −0
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+111 −34
- typo3/sysext/form/Configuration/Yaml/Finishers/EmailToReceiver.yaml+6 −0
- typo3/sysext/form/Configuration/Yaml/Finishers/EmailToSender.yaml+6 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Form.yaml+30 −0
- typo3/sysext/form/Configuration/Yaml/Legacy/mixins.yaml+15 −0
- typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Yaml/NewForms/SimpleContactForm.yaml+2 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.htmlnew+45 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.txtnew+16 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf2+30 −0
Review log 1420
-
Oli Bartsch uploaded patch set 1 09/26/20, 14:56
-
Oli Bartsch uploaded patch set 2 09/26/20, 15:05
-
Oli Bartsch uploaded patch set 3 09/26/20, 15:09
-
TYPO3com voted on patch set 1 V +1 09/26/20, 15:09 Completed build in 13m 03s on Sat, 26 Sep, 03:09 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-516
-
TYPO3com voted on patch set 2 V +1 09/26/20, 15:17 Completed build in 12m 17s on Sat, 26 Sep, 03:17 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-517
-
TYPO3com voted on patch set 3 V -1 09/26/20, 15:22 Completed build in 12m 47s on Sat, 26 Sep, 03:22 PM Test Summary: 1 of 75234 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-518
-
Oli Bartsch uploaded patch set 4 09/26/20, 16:14
-
TYPO3com voted on patch set 4 V +1 09/26/20, 16:26 Completed build in 12m 05s on Sat, 26 Sep, 04:26 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-519
-
Benni Mack commented on patch set 4 09/28/20, 08:44
-
Oli Bartsch uploaded patch set 5 09/28/20, 09:04
-
Oli Bartsch uploaded patch set 6 09/28/20, 09:06
-
Oli Bartsch commented on patch set 6 09/28/20, 09:07
> Patch Set 4: > > (1 comment)Database.xlf:153ReplyDone -
TYPO3com voted on patch set 5 V +1 09/28/20, 09:18 Completed build in 13m 25s on Mon, 28 Sep, 09:18 AM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-540
-
TYPO3com voted on patch set 6 V +1 09/28/20, 09:21 Completed build in 12m 53s on Mon, 28 Sep, 09:20 AM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-541
-
Daniel Goerz commented on patch set 6 V +1 CR +1 09/28/20, 13:13
Both ways of sending mails via finisher still work -
Benni Mack voted on patch set 6 V +2 CR +2 09/29/20, 04:57
-
Benni Mack merged patch set 7 09/29/20, 04:57
-
Martin Kutschker commented on patch set 7 01/18/21, 14:16
The RST is wrong.Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:29None of the Fluid root pathes are used in the code.Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:51addHtmlPart has no effect when usig FluidEmail. -
Oli Bartsch commented on patch set 7 01/18/21, 15:56
Reply
Tested it again and everything still works as advertised.Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:29ReplyThey are. See https://github.com/TYPO3/TYPO3.CMS/blob/10.4/typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php#L262. You have to either set templateName as described in the example below or use the default name "Default" see: https://github.com/TYPO3/TYPO3.CMS/blob/10.4/typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php#L296.Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:51Reply -
Martin Kutschker commented on patch set 7 01/18/21, 19:06
All is well, sorry for false alarm.Reply
AckFeature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:29ReplyI goofed, it's in the initialzing method.Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rst:51ReplyAck
Database.xlf:153