Review main Merged

65902[TASK] Remove Build/phpstan.level2.neon

Alexander Schnitzler CR +2 V +2 Normal +7 −60 updated 09/26/20, 16:37

Commit message

Since all level 2 rules are active and only level 2
parameters are set to different values compared to
their originally declared value, the whole file can
be removed, the overall phpstan level can be raised
to 2 and the parameters can be defined in the main
phpstan file.

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 67

  1. Alexander Schnitzler uploaded patch set 1 09/26/20, 15:10

  2. Alexander Schnitzler wrote 09/26/20, 15:10

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V +1 09/26/20, 15:29 Completed build in 15m 09s on Sat, 26 Sep, 03:29 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5989

  4. Daniel Goerz voted on patch set 1 V +1 CR +1 09/26/20, 15:56

  5. Oliver Klee voted on patch set 1 CR +1 09/26/20, 15:58

  6. Alexander Schnitzler voted on patch set 1 V +2 CR +2 09/26/20, 16:37

  7. Alexander Schnitzler merged patch set 2 09/26/20, 16:37