Review main Merged

65903[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:redirects

Daniel Goerz CR +2 V +2 Easy +6 −3 updated 09/27/20, 13:10

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 911

  1. Daniel Goerz uploaded patch set 1 09/26/20, 15:26

  2. TYPO3com voted on patch set 1 V +1 09/26/20, 15:39 Completed build in 12m 51s on Sat, 26 Sep, 03:39 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5990

  3. Daniel Goerz commented on patch set 1 09/26/20, 15:46

  4. Daniel Goerz uploaded patch set 2 09/26/20, 15:54

  5. Daniel Goerz voted on patch set 2 V +1 CR +1 09/26/20, 15:54

  6. Oliver Klee voted on patch set 2 CR +1 09/26/20, 15:58

  7. TYPO3com voted on patch set 2 V +1 09/26/20, 16:06 Completed build in 11m 44s on Sat, 26 Sep, 04:06 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5991

  8. Daniel Goerz wrote 09/26/20, 16:13

    Topic set to phpstan
  9. Oli Bartsch voted on patch set 2 V +1 CR +1 09/26/20, 16:41

  10. Daniel Goerz voted on patch set 2 V +2 CR +2 09/27/20, 13:10

  11. Daniel Goerz merged patch set 3 09/27/20, 13:10