Review main Merged

65904[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:recycler

Daniel Goerz CR +2 V +2 Easy +5 −3 updated 09/27/20, 12:31

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 910

  1. Daniel Goerz uploaded patch set 1 09/26/20, 16:01

  2. Daniel Goerz commented on patch set 1 09/26/20, 16:02

  3. Daniel Goerz voted on patch set 1 V +1 CR +1 09/26/20, 16:03

  4. Daniel Goerz wrote 09/26/20, 16:14

    Topic set to phpstan
  5. TYPO3com voted on patch set 1 V +1 09/26/20, 16:14 Completed build in 12m 42s on Sat, 26 Sep, 04:14 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5992

  6. Oli Bartsch voted on patch set 1 V +1 CR +1 09/26/20, 16:35

  7. Oliver Klee voted on patch set 1 CR +1 09/26/20, 17:22

  8. Guido Schmechel voted on patch set 1 CR +1 09/26/20, 22:28

  9. Andreas Kienast voted on patch set 1 V +2 CR +2 09/27/20, 12:31

  10. Andreas Kienast merged patch set 2 09/27/20, 12:31