65905[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:recordlist
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+2 −2
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+2 −2
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+1 −1
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+5 −4
Review log 911
-
Daniel Goerz uploaded patch set 1 09/26/20, 16:06
-
Daniel Goerz commented on patch set 1 09/26/20, 16:07
Extracted from https://review.typo3.org/c/Packages/TYPO3.CMS/+/65540 -
Daniel Goerz uploaded patch set 2 09/26/20, 16:10
-
Daniel Goerz wrote 09/26/20, 16:13
Topic set to phpstan -
Daniel Goerz voted on patch set 2 V +1 CR +1 09/26/20, 16:20
-
TYPO3com voted on patch set 1 V +1 09/26/20, 16:20 Completed build in 14m 10s on Sat, 26 Sep, 04:20 PM Test Summary: 73703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5993
-
TYPO3com voted on patch set 2 V +1 09/26/20, 16:24 Completed build in 14m 28s on Sat, 26 Sep, 04:24 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5994
-
Oli Bartsch voted on patch set 2 V +1 CR +1 09/26/20, 16:58
-
Oliver Klee voted on patch set 2 CR +1 09/26/20, 17:23
-
Andreas Kienast voted on patch set 2 V +2 CR +2 09/27/20, 14:33
-
Andreas Kienast merged patch set 3 09/27/20, 14:33