Review main Merged

65905[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:recordlist

Daniel Goerz CR +2 V +2 Easy +12 −11 updated 09/27/20, 14:33

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 911

  1. Daniel Goerz uploaded patch set 1 09/26/20, 16:06

  2. Daniel Goerz commented on patch set 1 09/26/20, 16:07

  3. Daniel Goerz uploaded patch set 2 09/26/20, 16:10

  4. Daniel Goerz wrote 09/26/20, 16:13

    Topic set to phpstan
  5. Daniel Goerz voted on patch set 2 V +1 CR +1 09/26/20, 16:20

  6. TYPO3com voted on patch set 1 V +1 09/26/20, 16:20 Completed build in 14m 10s on Sat, 26 Sep, 04:20 PM Test Summary: 73703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5993

  7. TYPO3com voted on patch set 2 V +1 09/26/20, 16:24 Completed build in 14m 28s on Sat, 26 Sep, 04:24 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5994

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 09/26/20, 16:58

  9. Oliver Klee voted on patch set 2 CR +1 09/26/20, 17:23

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 09/27/20, 14:33

  11. Andreas Kienast merged patch set 3 09/27/20, 14:33