65907[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:lowlevel
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Daniel Goerz +2
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/lowlevel/Classes/Command/FilesWithMultipleReferencesCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/LostFilesCommand.php+5 −2
- typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php+1 −0
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+1 −1
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+19 −19
Review log 1317
-
Daniel Goerz uploaded patch set 1 09/26/20, 16:28
-
Daniel Goerz commented on patch set 1 09/26/20, 16:29
Extracted from https://review.typo3.org/c/Packages/TYPO3.CMS/+/65540 -
Daniel Goerz updated the commit message in patch set 2 09/26/20, 16:29
-
Daniel Goerz wrote 09/26/20, 16:29
Topic set to phpstan -
TYPO3com voted on patch set 1 V +1 09/26/20, 16:41 Completed build in 12m 22s on Sat, 26 Sep, 04:41 PM Test Summary: 73703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5996
-
TYPO3com voted on patch set 2 V +1 09/26/20, 16:46 Completed build in 14m 58s on Sat, 26 Sep, 04:46 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5997
-
Daniel Goerz uploaded patch set 3 09/26/20, 17:01
-
TYPO3com voted on patch set 3 V +1 09/26/20, 17:13 Completed build in 11m 34s on Sat, 26 Sep, 05:13 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5999
-
Oliver Klee voted on patch set 3 CR +1 09/26/20, 17:22
-
Andreas Kienast commented on patch set 3 V -1 09/27/20, 14:44
------ ---------------------------------------------------------------------------- Line Classes/Database/QueryGenerator.php ------ ---------------------------------------------------------------------------- 1655 Parameter #1 $input of function array_slice expects array, string given. 1656 Parameter #1 $input of function array_slice expects array, string given. 1657 Parameter #1 $stack of function array_shift expects array, string given. 1660 Parameter #1 $arr1 of function array_merge expects array, string given. 1660 Parameter #3 ...$args of function array_merge expects array, string given. ------ ---------------------------------------------------------------------------- -
Andreas Kienast uploaded patch set 4 09/27/20, 14:48
-
Oliver Klee voted on patch set 4 CR +1 09/27/20, 15:01
-
TYPO3com voted on patch set 4 V +1 09/27/20, 15:03 Completed build in 15m 21s on Sun, 27 Sep, 03:03 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6027
-
Benni Mack commented on patch set 4 10/01/20, 13:40
although this is now syntactically correct, the result looks a bit wild (casting int/string for 1 => '1' values) -
Alexander Schnitzler voted on patch set 4 V +1 CR +1 10/06/20, 10:43
-
Daniel Goerz voted on patch set 4 V +2 CR +2 10/06/20, 11:18
-
Daniel Goerz merged patch set 5 10/06/20, 11:18