Review main Merged

65908[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:info

Daniel Goerz CR +2 V +2 Easy +11 −10 updated 09/27/20, 14:30

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 810

  1. Daniel Goerz uploaded patch set 1 09/26/20, 17:10

  2. Daniel Goerz wrote 09/26/20, 17:10

    Topic set to phpstan
  3. Daniel Goerz commented on patch set 1 09/26/20, 17:11

  4. Daniel Goerz uploaded patch set 2 09/26/20, 17:13

  5. Daniel Goerz voted on patch set 2 V +1 CR +1 09/26/20, 17:14

  6. Oliver Klee voted on patch set 2 CR +1 09/26/20, 17:21

  7. TYPO3com voted on patch set 1 V +1 09/26/20, 17:23 Completed build in 12m 36s on Sat, 26 Sep, 05:23 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6000

  8. TYPO3com voted on patch set 2 V +1 09/26/20, 17:28 Completed build in 14m 42s on Sat, 26 Sep, 05:28 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6001

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 09/27/20, 14:29

  10. Andreas Kienast merged patch set 3 09/27/20, 14:30