65909[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:indexed_search
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+12 −11
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+1 −1
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+6 −6
- typo3/sysext/indexed_search/Classes/Utility/IndexedSearchUtility.php+6 −6
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingResultsViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php+3 −3
- typo3/sysext/indexed_search/Classes/FileContentParser.php1+6 −3
- typo3/sysext/indexed_search/Classes/Indexer.php+2 −1
Review log 1215
-
Daniel Goerz uploaded patch set 1 09/26/20, 17:17
-
Daniel Goerz commented on patch set 1 09/26/20, 17:17
Extracted from https://review.typo3.org/c/Packages/TYPO3.CMS/+/65540 -
Daniel Goerz wrote 09/26/20, 17:17
Topic set to phpstan -
Oliver Klee voted on patch set 1 CR +1 09/26/20, 17:21
-
Daniel Goerz uploaded patch set 2 09/26/20, 17:26
-
TYPO3com voted on patch set 1 V +1 09/26/20, 17:31 Completed build in 13m 42s on Sat, 26 Sep, 05:31 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6002
-
TYPO3com voted on patch set 2 V +1 09/26/20, 17:38 Completed build in 11m 30s on Sat, 26 Sep, 05:38 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6003
-
Oliver Klee voted on patch set 2 CR +1 09/26/20, 17:49
-
Andreas Kienast uploaded patch set 3 09/27/20, 14:27
-
Andreas Kienast commented on patch set 3 V +1 CR +1 09/27/20, 14:27
FileContentParser.php:734UnresolvedMagic PHP -
TYPO3com voted on patch set 3 V +1 09/27/20, 14:44 Completed build in 15m 03s on Sun, 27 Sep, 02:44 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6024
-
Oliver Klee voted on patch set 3 CR +1 09/27/20, 15:01
-
Oli Bartsch voted on patch set 3 V +1 CR +1 09/28/20, 08:19
-
Benni Mack voted on patch set 3 V +2 CR +2 09/28/20, 08:26
-
Benni Mack merged patch set 4 09/28/20, 08:26