Review main Merged

65909[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:indexed_search

Daniel Goerz CR +2 V +2 Normal +37 −32 updated 09/28/20, 08:26

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1215

  1. Daniel Goerz uploaded patch set 1 09/26/20, 17:17

  2. Daniel Goerz commented on patch set 1 09/26/20, 17:17

  3. Daniel Goerz wrote 09/26/20, 17:17

    Topic set to phpstan
  4. Oliver Klee voted on patch set 1 CR +1 09/26/20, 17:21

  5. Daniel Goerz uploaded patch set 2 09/26/20, 17:26

  6. TYPO3com voted on patch set 1 V +1 09/26/20, 17:31 Completed build in 13m 42s on Sat, 26 Sep, 05:31 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6002

  7. TYPO3com voted on patch set 2 V +1 09/26/20, 17:38 Completed build in 11m 30s on Sat, 26 Sep, 05:38 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6003

  8. Oliver Klee voted on patch set 2 CR +1 09/26/20, 17:49

  9. Andreas Kienast uploaded patch set 3 09/27/20, 14:27

  10. Andreas Kienast commented on patch set 3 V +1 CR +1 09/27/20, 14:27

    FileContentParser.php:734 Unresolved

    Magic PHP
  11. TYPO3com voted on patch set 3 V +1 09/27/20, 14:44 Completed build in 15m 03s on Sun, 27 Sep, 02:44 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6024

  12. Oliver Klee voted on patch set 3 CR +1 09/27/20, 15:01

  13. Oli Bartsch voted on patch set 3 V +1 CR +1 09/28/20, 08:19

  14. Benni Mack voted on patch set 3 V +2 CR +2 09/28/20, 08:26

  15. Benni Mack merged patch set 4 09/28/20, 08:26